Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made EarlyDeleteHelper thread-safe #13727

Merged
merged 2 commits into from Mar 15, 2016
Merged

Made EarlyDeleteHelper thread-safe #13727

merged 2 commits into from Mar 15, 2016

Conversation

Dr15Jones
Copy link
Contributor

Switched to using atomic counters in order to avoid race conditions once we start using more than one thread per event.

@Dr15Jones
Made EarlyDeleteHelper thread-safe
e9dcd85 
Switched to using atomic counters in order to avoid race conditions once we start using more than one thread per event.
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 15, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Using meaningful names in BranchToCount
b3c5e63 
Changed names from first,second to branch,count to allow better self documentation.
@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11903/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@Dr15Jones Dr15Jones mentioned this pull request Mar 15, 2016
Closed
@cmsbuild
Copy link
Contributor

+1
Tested at: b3c5e63
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13727/11903/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13727/11903/summary.html

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 15, 2016
@cmsbuild
Merge pull request #13727 from Dr15Jones/fixGuardXrdRequestManager
0f17fc0 
Made EarlyDeleteHelper thread-safe
@cmsbuild cmsbuild merged commit 0f17fc0 into cms-sw:CMSSW_8_1_X Mar 15, 2016
@Dr15Jones Dr15Jones deleted the fixGuardXrdRequestManager branch March 28, 2016 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @davidlange6