Fix RectangularEtaPhiTrackingRegion (76X)

[makortel]

Backport of #13729. Original description:

This PR fixes a bug introduced in #11624, where in an if statement a pixel barrel was required, but it should have been pixel endcap.

Tested in 7_6_0. In the PR tests there are probably no changes visible because the affected code path does not get run.

@rovere @VinInn

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

It involves the following packages:

RecoTracker/TkTrackingRegions

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

What's the use case for 76X?

[VinInn]

@fwyzard told us that they are "validating" HLT 76 vs 74.
MC production with 76x is not excluded
I do not see any reason to leave a potential bug in an active release.

[VinInn]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11911/console

[VinInn]

I confirm that at least in current MC workflows UseMeasurementTracker is never 1.
so the bug is harmless and went undetected for a "good" reason.

[cmsbuild]

+1
Tested at: eee116c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13731/11911/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13731/11911/summary.html

[fwyzard]

Hi Vincenzo,

I confirm that at least in current MC workflows UseMeasurementTracker is
never 1.
so the bug is harmless and went undetected for a "good" reason.

Thanks for confirming this.

.A

[cvuosalo]

+1

For #13731 eee116c

Fixing a tracking region bug that is probably actually never encountered in standard workflows. It should probably be safe to merge this PR into 76X since it appears the bug never occurred in previously produced 76X MC.

There should be no change in monitored quantities.

#13729 and #13739 are the 81X and 80X versions of this PR, and they both have already been approved.

Jenkins tests against baseline CMSSW_7_6_X_2016-03-13-0000 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1