Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need unqiue cfi file names in fillDescription to avoid overwriting in HLT (81X) #13732

Merged
merged 3 commits into from Mar 16, 2016

Conversation

Martin-Grunewald
Copy link
Contributor

Need unqiue cfi file names in fillDescription to avoid overwriting in HLT (81X)
For ConfDB parsing
Added missing cfi file for new plugin

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@abbiendi, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11910/console

@cmsbuild
Copy link
Contributor

Pull request #13732 was updated. @perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #13732 was updated. @perrotta, @cmsbuild, @diguida, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

-1
Tested at: 44581c4
I found an error when building:

In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/HLTrigger/special/src/HLTDTROMonitorFilter.cc:15:0:
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-03-15-1100/src/DataFormats/DTDigi/interface/DTDDUWords.h:1:1: warning: null character(s) ignored
  
 ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/HLTrigger/special/src/HLTDTROMonitorFilter.cc: In member function 'virtual bool HLTDTROMonitorFilter::filter(edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/HLTrigger/special/src/HLTDTROMonitorFilter.cc:61:2: error: 'DTDDUFirstStatusWord' was not declared in this scope
  DTDDUFirstStatusWord statusWord(index8[wordIndex8]);
  ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/HLTrigger/special/src/HLTDTROMonitorFilter.cc:63:5: error: 'statusWord' was not declared in this scope
  if(statusWord.errorFromROS() != 0 || statusWord.eventTrailerLost() != 0) return true;
     ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13732/11910/summary.html

@Martin-Grunewald
Copy link
Contributor Author

unrelated error - this PR does not touch the file complained about!

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11916/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13732/11916/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@Martin-Grunewald
Copy link
Contributor Author

+1

davidlange6 added a commit that referenced this pull request Mar 16, 2016
Need unqiue cfi file names in fillDescription to avoid overwriting in HLT (81X)
@davidlange6 davidlange6 merged commit 3252410 into cms-sw:CMSSW_8_1_X Mar 16, 2016
@Martin-Grunewald Martin-Grunewald deleted the FixMuonMigration81X branch March 22, 2016 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants