Remove unneeded selector #13735
Remove unneeded selector #13735
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
-1 >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/UnitTestClient_C.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/ProblemTestClient_t1.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/UnitTestClient_Hd.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/UnitTestClient_W.cc
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/UnitTestClient_T.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/UnitTestClient_T.h:66:29: error: 'ErrorSummaryEntry' is not a member of 'edm'
void printLES(std::vectoredm::ErrorSummaryEntry const & v);
^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/UnitTestClient_T.h:66:29: error: 'ErrorSummaryEntry' is not a member of 'edm'
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-15-1100/src/FWCore/MessageService/test/UnitTestClient_T.h:66:51: error: template argument 1 is invalid
void printLES(std::vectoredm::ErrorSummaryEntry const & v);
you can see the results of the tests here: |
cmsbuild
added
tests-rejected
comparison-pending
and removed
comparison-notrun
tests-started
labels
|
-1 Tested at: 41b4990 ---> test runtestTqafTopEventSelection had ERRORS you can see the results of the tests here: |
|
@cmsbuild @Dr15Jones @davidlange6 The unit test failure is in the base IB, and has nothing to do with this PR. |
|
@Dr15Jones When you have the time, can you either make suggestions for changes, or sign it. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Minor internal framework improvement.
The current code uses a default event selector when there is no event selection, i.e. all events are selected. However, output modules were recently modified to enforce the consumes interface.
This required a new NamedEventSelector constructor to enforce the consumes interface. However, the default event selector does not consume anything, so the prior constructor was needed just for it.
Chris Jones commented that this old constructor should be removed if no longer needed.
This PR removes the default selector, and replaces it with a simple bool wantAllEvents_ flag, thereby simplifying the code.