Fix typo in Types.py #13738
Fix typo in Types.py #13738
Conversation
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
Good catch. How was this found? |
|
please test |
|
The tests are being triggered in jenkins. |
|
Can you expand the unit test for this file to show the problem is solved? |
|
Pull request #13738 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again. |
|
@Dr15Jones Here is a unit test that fails without the fix (although I'm not sure about the robustness of the test). |
|
please test |
|
The tests are being triggered in jenkins. |
|
Thanks for the test |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
cmsbuild
added
tests-approved
comparison-pending
and removed
comparison-available
tests-started
labels
|
+1 |
While debugging something else, I encountered this obvious typo. In the end it was not the cause of my problem (I was trying to do
cms.bool("False")instead ofcms.bool(False)and noticed it only afterwards), here is anyway a fix.Tested in CMSSW_8_1_0_pre1, no changes expected.