Remove duplicated functions in Provenance.h #13765
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: DataFormats/Provenance @perrotta, @smuzaffar, @Dr15Jones, @Martin-Grunewald, @cmsbuild, @deguio, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
-1 /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-03-17-1100/src/SimDataFormats/ValidationFormats/interface/MaterialAccountingDetector.h:1:1: warning: null character(s) ignored
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-17-1100/src/SimTracker/TrackAssociatorProducers/plugins/TrackAssociatorByPositionProducer.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-17-1100/src/SimTracker/TrackAssociatorProducers/plugins/QuickTrackAssociatorByHitsImpl.cc
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-17-1100/src/SimTracker/TrackAssociatorProducers/plugins/TrackAssociatorByHitsImpl.cc
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-17-1100/src/SimTracker/TrackerMaterialAnalysis/plugins/TrackingMaterialPlotter.cc: In member function 'void TrackingMaterialPlotter::plotSegmentUnassigned(const MaterialAccountingStep&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-17-1100/src/SimTracker/TrackerMaterialAnalysis/plugins/TrackingMaterialPlotter.cc:125:14: error: invalid use of incomplete type 'const class MaterialAccountingStep'
w[0] = step.radiationLengths();
^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-17-1100/src/SimTracker/TrackerMaterialAnalysis/plugins/TrackingMaterialPlotter.cc:10:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-03-17-1100/src/SimTracker/TrackerMaterialAnalysis/plugins/TrackingMaterialPlotter.h:14:7: note: forward declaration of 'class MaterialAccountingStep'
class MaterialAccountingStep;
you can see the results of the tests here: |
cmsbuild
added
tests-rejected
comparison-pending
and removed
comparison-notrun
tests-started
labels
|
Please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 8d56aac ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
Remove duplicated functions in Provenance.h
For historical reasons, the class "Provenance" has three different member functions that are identical except for the function name. This PR removes two of them, constBranchDescription() and product(), and replaces calls to them with calls to the existing identical function, branchDescription().
It also replaces two iterator loops with two C++11 range based for loops in a file that was modified anyway. This PR should not cause any functional changes whatever.