Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muon dqm fix missing histos #1377

Merged
merged 4 commits into from Nov 11, 2013
Merged

Conversation

folguera
Copy link
Contributor

@folguera folguera commented Nov 8, 2013

We were missing lots of histograms due to not calling correctly SetCurrentFolder on the DQMStore.
Added muonAnalyzer_noHLT sequence for allowing running without any trigger configuration (this will need to be backported to 62X_SLHX)
Put back CSC into the sequence as well as MuonPFAnalyzer.
Added getByToken and consumes declaration into MuonPFAnalyzer (was skipped in the previous pull request)

…k CSC to the sequence, remove getByLabel references from MuonPFAnalyzer
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

A new Pull Request was created by @folguera (Santiago Folgueras) for CMSSW_7_0_X.

Muon dqm fix missing histos

It involves the following packages:

DQMOffline/Muon

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/FWCore/Version/src/GetReleaseVersion.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/Validation/RecoParticleFlow/bin/PlotCompareUtility.cpp 
Entering library rule at src/Validation/RecoParticleFlow/bin
>> Compiling LCG dictionary: tmp/slc5_amd64_gcc481/src/Validation/RecoParticleFlow/src/ValidationRecoParticleFlow/a/xr.cc
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/DQMOffline/Muon/src/MuonRecoOneHLT.cc: In constructor 'MuonRecoOneHLT::MuonRecoOneHLT(const edm::ParameterSet&)':
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/DQMOffline/Muon/src/MuonRecoOneHLT.cc:23:68: error: no matching function for call to 'GenericTriggerEventFlag::GenericTriggerEventFlag(edm::ParameterSet&)'
   _SingleMuonEventFlag     = new GenericTriggerEventFlag( muonparms); //, consumesCollector() );
                                                                    ^
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/DQMOffline/Muon/src/MuonRecoOneHLT.cc:23:68: note: candidates are:
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/DQMOffline/Muon/interface/MuonRecoOneHLT.h:22:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-11-08-0200/src/DQMOffline/Muon/src/MuonRecoOneHLT.cc:1:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1254/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

Pull request #1377 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

@deguio
Copy link
Contributor

deguio commented Nov 8, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 11, 2013
DQM fixes -- Muon dqm fix missing histos
@ktf ktf merged commit 355daae into cms-sw:CMSSW_7_0_X Nov 11, 2013
@folguera folguera deleted the MuonDQM-FixMissingHistos branch November 13, 2013 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants