Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in CorrelationConditions uGT emulator #13808

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Mar 23, 2016

Missing instantiation of candEtSumVec. Also added checks of types.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Mar 23, 2016

please test

@Martin-Grunewald
Copy link
Contributor

please test
@rekovic
please ask for L2 privileges for "L1"

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12012/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 241df34
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 23-Mar-2016 10:40:17 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

4.22 step1

DAS Error

134.911 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13808/12012/summary.html

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12016/console

@rekovic
Copy link
Contributor Author

rekovic commented Mar 23, 2016

@Martin-Grunewald

please ask for L2 privileges for "L1"

PR cms-sw/cms-bot#650. Hopefully granted soon.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@rekovic
Copy link
Contributor Author

rekovic commented Mar 23, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c19aa9a into cms-sw:CMSSW_8_1_X Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants