bsunanda:Run2-hcx76 Remove obsolete parameter definitions for relabelling at DIGI step

[bsunanda]

No description provided.

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Geometry/HcalEventSetup
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry
SimCalorimetry/HcalSimProducers

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12036/console

[cmsbuild]

+1
Tested at: 08b5da3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13822/12036/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13822/12036/summary.html

[cmsbuild]

Pull request #13822 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12054/console

[cmsbuild]

+1
Tested at: 7a535b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13822/12054/summary.html

[civanch]

@bsunanda, in the workflow 8.0 one plot is not identical for Hcal. Can you, please, have a look.

[bsunanda]

I took a look and cannot understand what could cause any difference in the RawTask for HCal. All changes made here are removing some of the parameters which are never read in by the code and are simply legacy parameters. The difference is ertainly not due to changes made in the PR.

---

From: Vladimir Ivantchenko [notifications@github.com]
Sent: 27 March 2016 12:37
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx76 Remove obsolete parameter definitions for relabelling at DIGI step (#13822)

@bsunandahttps://github.com/bsunanda, in the workflow 8.0 one plot is not identical for Hcal. Can you, please, have a look.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com//pull/13822#issuecomment-202032787

[Dr15Jones]

Is it possible that you have an uninitialized variable? If so, removing member data could move the location of that memory to somewhere with a different value.

[bsunanda]

Hi Chris - all the changes are in the cfi/cff files. The only change in code is theRelabeller=new HcalHitRelabeller(ps0.getUntrackedParameteredm::ParameterSet("RelabelRules"));
replaced with
theRelabeller=new HcalHitRelabeller(ps0);
and HcalHitRelabller does not use the parameterset. So should I investigate the code where this change is made for uninitialized variable. But this is digitizer code and the complaint comes from RAW part. I am at a loss.

---

From: Chris Jones [notifications@github.com]
Sent: 28 March 2016 16:12
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx76 Remove obsolete parameter definitions for relabelling at DIGI step (#13822)

Is it possible that you have an uninitialized variable? If so, removing member data could move the location of that memory to somewhere with a different value.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com//pull/13822#issuecomment-202408751

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12083/console

[cmsbuild]

+1
Tested at: 7a535b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13822/12083/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13822/12083/summary.html

[civanch]

+1
in the new test all workflows are OK. I would think that Chris probably right but this is not related to this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar