HGCal Reworked rechit scheme

[lgray]

HGC Rechits are reworked such that uncalibrated Rechits are in MIPs.

This is preparation towards having an EM calibrated RecHit.

Also, the hexagon geometry is made default in unit tests from now on.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers
RecoParticleFlow/PFClusterProducer
SimCalorimetry/HGCalSimProducers

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @mmarionncern, @kpedro88, @argiro, @cseez, @pfs, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12061/console

[cmsbuild]

+1
Tested at: ce7b1a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13835/12061/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13835/12061/summary.html

[civanch]

+1

[cvuosalo]

Please check if fCPerMIP_[thickness-1] is zero before dividing by it.

[lgray]

I will check this in the constructor so it is guaranteed non-zero here.

[cvuosalo]

The static analyzer complains about SimCalorimetry/HGCalSimProducers/src/HGCHEbackDigitizer.cc. It would be nice to get the issue fixed at some point. Lines 59-64 could be changed as follows.

59    float totalMIPs(totalIniMIPs);

Value stored to 'totalMIPs' during its initialization is never read
60        const float xtalk = (nTotalPE_-xTalk_*((float)nPixel))/(nTotalPE_-((float)nPixel));
61        if( nTotalPE_ != nPixel && xtalk > 0. )
62          totalMIPs = (nTotalPE_/nPEperMIP_)*vdt::fast_logf(xtalk);
63        else
64          totalMIPs = 0.f;

to

float totalMIPs(0.f), 
const float xtalk = 0.f,  peDiff = nTotalPE_ - (float) nPixel;
if (peDiff != 0.) {
  xtalk = (nTotalPE_-xTalk_*((float)nPixel)) / peDiff;
  if( xtalk > 0. && nPEperMIP_ != 0.)
   totalMIPs = (nTotalPE_/nPEperMIP_)*vdt::fast_logf(xtalk);
}

It could be the line totalMIPs = 0.f; is incorrect, so the initialization float totalMIPs(totalIniMIPs); would actually be correct.

[lgray]

@cvuosalo Thanks for the review. I am taking care of it now.

[cmsbuild]

Pull request #13835 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[lgray]

@cmsbuild please test

I have addressed the code review.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12163/console

[cmsbuild]

+1
Tested at: 4f5269c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13835/12163/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13835/12163/summary.html

[cvuosalo]

+1

For #13835 4f5269c

Revising HGCal rec hits. There should be no change in standard (non-HGCal) workflows.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-04-04-1100 show no significant differences, as expected.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1