Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv test record.cppunit.cpp from DataFormats/FWLite to PhysicsTools/Co… #13859

Merged

Conversation

Dr15Jones
Copy link
Contributor

…ndLiteIO

In order to remove dependencies of DataFormats/FWLite on PhysicsTools/CondLiteIO
we needed to move the test of the lite EventSetup system. The test needs
PhysicsTools/CondLiteIO to create the test file.

…ndLiteIO

In order to remove dependencies of DataFormats/FWLite on PhysicsTools/CondLiteIO
we needed to move the test of the lite EventSetup system. The test needs
PhysicsTools/CondLiteIO to create the test file.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/FWLite
PhysicsTools/CondLiteIO

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

This is meant to help with the stand alone version of the framework: Stitched

@sextonkennedy @smuzaffar

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12093/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 58dccb8
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13859/12093/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4a20228
161217c
c32369e
50a3872
1841cae
4671860
cae5e3b
0025a30
5e65373
10d3272
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13859/12093/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13859/12093/git-merge-result

@cmsbuild
Copy link
Contributor

@davidlange6 davidlange6 merged commit b5b126e into cms-sw:CMSSW_8_1_X Mar 30, 2016
@Dr15Jones Dr15Jones deleted the mvFWLiteEventSetupTestToPhysicsTools branch April 5, 2016 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants