Configurable hardcode conditions for HCAL #13861

kpedro88 · 2016-03-30T00:03:08Z

This PR modifies HcalHardcodeConditions and HcalDbHardcode to make basic parameters configurable using Python. This change is intended to aid reconstruction development for the 2017 HF and HE upgrades, respectively: dual anode readout with QIE10 and SiPMs with QIE11 and increased depth segmentation.

NB: Nothing should change in existing workflows, because the hardcode conditions are only used for development.

Elements of this PR:

New class HcalHardcodeParameters (modeled after HcalSimParameters), currently contains pedestal, pedestal width, gain, gain width, QIE type, QIE offsets (range 0-3), QIE slopes (range 0-3)
HcalDbHardcode now a class (instead of a namespace)
Fixed any HcalDbHardcode dependencies accordingly (or removed unnecessary includes, in one case deleted an unused piece of code after discussion on HCAL CMSSW hypernews)
Hcal_Conditions_forGlobalTag_cff has PSets for:HB, HE, HF, HO, HB upgrade, HE upgrade, HF upgrade
Each subdetector can be set to Run1 or upgrade independently (testHFQIE10 “mixed case” still available)
Run1 parameters based on dump of DB conditions from 7_6_3 (GT auto:run2_mc) + HcalQIEData_NormalMode_v7.05_mc for QIEData (newer tag)
SiPM lumi offset and pedestal width lumi dependence parameters also now configurable (may be supplanted by new noise & raddam models in the future)
Added a customization function customise_HcalPhase0p5 ("Phase 0.5"). Currently this enables QIE10 digitization for all HF cells, but keeps Run1 conditions for HE (SiPM + QIE11 not ready yet).

I've tested the 2017 mode in CMSSW_8_1_X_2016-03-29-2300 with customise_HcalPhase0p5 and the Extended2017dev geometry, which has HF depths 3/4 and HE depths up to 7. I used the following script:

#!/bin/bash

 cmsDriver.py SinglePiE50HCAL_pythia8_cfi  --conditions auto:phase1_2017_design -n 10 --era Run2_2017 --geometry "Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff" --eventcontent FEVTDEBUG -s GEN,SIM --datatier GEN-SIM --beamspot Realistic50ns13TeVCollision --fileout file:step1.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_HcalPhase0p5 > step1_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1


 cmsDriver.py step2  --conditions auto:phase1_2017_design -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval25ns --datatier GEN-SIM-DIGI-RAW-HLTDEBUG -n 10 --era Run2_2017 --geometry "Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff" --eventcontent FEVTDEBUGHLT --filein file:step1.root  --fileout file:step2.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_HcalPhase0p5 > step2_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1


 cmsDriver.py step3  --runUnscheduled  --conditions auto:phase1_2017_design -s RAW2DIGI,L1Reco,RECO,EI,PAT --datatier GEN-SIM-RECO,MINIAODSIM -n 10 --era Run2_2017 --geometry "Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff" --eventcontent RECOSIM,MINIAODSIM --filein file:step2.root  --fileout file:step3.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_HcalPhase0p5 > step3_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1


 cmsDriver.py step4  --runUnscheduled  --conditions auto:phase1_2017_design -s VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO -n 10 --era Run2_2017 --geometry "Configuration.Geometry.GeometryExtended2017dev_cff,Configuration.Geometry.GeometryExtended2017devReco_cff" --eventcontent RECOSIM,MINIAODSIM,DQM --filein file:step3.root  --fileout file:step4.root --customise SLHCUpgradeSimulations/Configuration/HCalCustoms.customise_HcalPhase0p5 > step4_SinglePiE50_UP15+SinglePiE50_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log  2>&1

The DIGI and RECO steps both actually succeed, though with some errors that need to be resolved. Validation/DQM fail, which is why I moved them to a separate step.

cmsbuild · 2016-03-30T00:03:30Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
CondTools/Hcal
IORawData/CaloPatterns
OnlineDB/HcalCondDB
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HcalSimAlgos

The following packages do not have a category, yet:

OnlineDB/HcalCondDB

@civanch, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

mmusich · 2016-03-30T05:43:10Z

please test

cmsbuild · 2016-03-30T05:43:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12095/console

cmsbuild · 2016-03-30T07:56:36Z

+1
Tested at: 6db3055
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13861/12095/summary.html

cmsbuild · 2016-03-30T09:13:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13861/12095/summary.html

kpedro88 · 2016-03-30T23:17:33Z

@mmusich @ggovi @civanch - The comparison looks good to me. Again, no changes expected in standard workflows. Nevertheless, there should probably be some code review, since this is a moderately large change, even though it's only used for testing new features.

@davidlange6 - OnlineDB/HcalCondDB should probably be added to the 'db' category...

kpedro88 · 2016-03-31T19:51:50Z

NB: I just updated the 2017 dev testing recipe in the PR message so that the RECO step can actually run.

cmsbuild · 2016-04-01T03:58:07Z

Pull request #13861 was updated. @civanch, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

kpedro88 · 2016-04-01T03:59:30Z

Added a commit to remove DIGI2RAW and RAW2DIGI for HCAL in the Phase0p5 customization. This is necessary to get the new depths in HE to show up in RecHits. Otherwise, they get discarded in some step of the packing and unpacking. We're looking into what's needed to make the full chain work (probably FED lists, etc.); in the meantime, this solution was used for the UpgradeDataFrames in the past.

civanch · 2016-04-02T19:41:00Z

please test

cmsbuild · 2016-04-02T19:41:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12142/console

cmsbuild · 2016-04-11T15:52:43Z

+1
Tested at: e13eead
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13861/12288/summary.html

cmsbuild · 2016-04-11T16:50:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13861/12288/summary.html

kpedro88 · 2016-04-11T16:54:33Z

Comparison still looks fine. Rebase just had to include the technical change auto_ptr -> unique_ptr from #13999.

@civanch @ggovi @mmusich can you sign again?

kpedro88 · 2016-04-12T20:50:14Z

@civanch @ggovi @mmusich @davidlange6 - please sign and merge ASAP as discussed in ORP this morning...

mmusich · 2016-04-13T06:47:00Z

+1

abdoulline · 2016-04-13T09:52:51Z

@civanch
@ggovi

please, approve.

civanch · 2016-04-13T10:00:58Z

+1

ggovi · 2016-04-13T12:57:45Z

+1

cmsbuild · 2016-04-13T12:58:07Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-04-13T13:50:57Z

+1

cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 30, 2016

cmsbuild added simulation-pending alca-pending db-pending pending-signatures tests-pending orp-pending new-package-pending comparison-pending labels Mar 30, 2016

cmsbuild added tests-started and removed tests-pending labels Mar 30, 2016

cmsbuild added tests-approved and removed tests-started labels Mar 30, 2016

cmsbuild added comparison-available and removed comparison-pending labels Mar 30, 2016

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Apr 1, 2016

cmsbuild added the tests-started label Apr 11, 2016

cmsbuild added tests-approved and removed tests-started labels Apr 11, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 11, 2016

cmsbuild added alca-approved and removed alca-pending labels Apr 13, 2016

cmsbuild added simulation-approved and removed simulation-pending labels Apr 13, 2016

cmsbuild added fully-signed db-approved and removed db-pending pending-signatures labels Apr 13, 2016

cmsbuild added orp-approved and removed orp-pending labels Apr 13, 2016

cmsbuild merged commit f9c8c0d into cms-sw:CMSSW_8_1_X Apr 13, 2016

This was referenced Apr 15, 2016

HCAL Phase1 bug fixes #14101

Merged

[FWCore] Feature request: Python script to generate C++ fillDescriptions code from config #14105

Closed

kpedro88 mentioned this pull request Nov 8, 2016

Update SiPM parameters and fix a few bugs in hardcode conditions #16526

Merged

cmsbuild mentioned this pull request Nov 16, 2016

Update SiPM parameters and fix a few bugs in hardcode conditions #16607

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configurable hardcode conditions for HCAL #13861

Configurable hardcode conditions for HCAL #13861

kpedro88 commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

mmusich commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

kpedro88 commented Mar 30, 2016

kpedro88 commented Mar 31, 2016

cmsbuild commented Apr 1, 2016

kpedro88 commented Apr 1, 2016

civanch commented Apr 2, 2016

cmsbuild commented Apr 2, 2016

cmsbuild commented Apr 11, 2016

cmsbuild commented Apr 11, 2016

kpedro88 commented Apr 11, 2016

kpedro88 commented Apr 12, 2016

mmusich commented Apr 13, 2016

abdoulline commented Apr 13, 2016

civanch commented Apr 13, 2016

ggovi commented Apr 13, 2016

cmsbuild commented Apr 13, 2016

davidlange6 commented Apr 13, 2016

Configurable hardcode conditions for HCAL #13861

Configurable hardcode conditions for HCAL #13861

Conversation

kpedro88 commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

mmusich commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

cmsbuild commented Mar 30, 2016

kpedro88 commented Mar 30, 2016

kpedro88 commented Mar 31, 2016

cmsbuild commented Apr 1, 2016

kpedro88 commented Apr 1, 2016

civanch commented Apr 2, 2016

cmsbuild commented Apr 2, 2016

cmsbuild commented Apr 11, 2016

cmsbuild commented Apr 11, 2016

kpedro88 commented Apr 11, 2016

kpedro88 commented Apr 12, 2016

mmusich commented Apr 13, 2016

abdoulline commented Apr 13, 2016

civanch commented Apr 13, 2016

ggovi commented Apr 13, 2016

cmsbuild commented Apr 13, 2016

davidlange6 commented Apr 13, 2016