Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation under EDM_ML_DEBUG #13885

Merged
merged 1 commit into from Apr 2, 2016
Merged

Fix compilation under EDM_ML_DEBUG #13885

merged 1 commit into from Apr 2, 2016

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Apr 1, 2016

I encountered some compilation failures while compiling large bunch of code with -DEDM_ML_DEBUG. Here is a suggestion to fix them.

Tested in CMSSW_8_1_X_2016-03-27-1100, no changes expected.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 1, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

DPGAnalysis/SiStripTools
RecoMuon/CosmicMuonProducer
RecoPixelVertexing/PixelLowPtUtilities

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @threus, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @bellan, @rovere, @cerati, @venturia, @trocino, @dgulhan, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 1, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12129/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

+1
Tested at: 6808546
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13885/12129/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13885/12129/summary.html

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 1, 2016

+1

For #13885 6808546

Clean-up of some debug messages. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-03-31-2300 show no significant differences, as expected.

@davidlange6 davidlange6 merged commit 468fb2a into cms-sw:CMSSW_8_1_X Apr 2, 2016
@makortel makortel deleted the fixDebug branch October 20, 2016 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available orp-pending pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makortel @cmsbuild @slava77 @cvuosalo @davidlange6