Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std::shared_ptr and std::make_shared (EventSetup in Analysis) #13894

Merged
merged 1 commit into from Apr 6, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Apr 2, 2016

The only place that the CMS framework still uses boost::shared_ptr is in the interface to the EventSetup system, where std::shared_ptr is also supported. In order to remove this last vestige of boost::shared_ptr,
users of EventSetup need to be converted to std::shared_ptr. This PR does this for Analysis packages.
Also, std::make_shared is implemented where it makes sense, because it simplifies the code and saves a memory allocation.
This PR is totally technical.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2016

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

JetMETCorrections/FFTJetModules
JetMETCorrections/FFTJetObjects
JetMETCorrections/Modules
PhysicsTools/CondLiteIO
PhysicsTools/MVAComputer

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@wmtan
Copy link
Contributor Author

wmtan commented Apr 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12135/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2016

-1

Tested at: c3fdad8
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13894/12135/summary.html

@wmtan
Copy link
Contributor Author

wmtan commented Apr 2, 2016

@cmsbuild @davidlange6 The unit test failure occurs in the base IB and has nothing to do with this PR.

@davidlange6 davidlange6 merged commit b44e577 into cms-sw:CMSSW_8_1_X Apr 6, 2016
@wmtan wmtan deleted the StdSharedPtrInAnalysis branch May 26, 2016 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants