bsunanda:Phase2-gem13 Correct forward muon part for 3 2023 scenario #13916
Conversation
|
@cmsbuild Please test |
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
The tests are being triggered in jenkins. |
| @@ -233,7 +233,7 @@ | |||
| 'Geometry/MuonCommonData/data/v7/gem21.xml', | |||
| 'Geometry/MuonCommonData/data/v2/csc.xml', | |||
| 'Geometry/MuonCommonData/data/PhaseII/mfshield.xml', | |||
| 'Geometry/MuonCommonData/data/PhaseII/me0.xml', | |||
| 'Geometry/MuonCommonData/data/v8/me0.xml', | |||
There was a problem hiding this comment.
@bsunanda - one may assume that if me0 is defined in v8, gem should also come from v8. Is there any reason to keep PhaseII/me0? Perhaps, replacing it with v8 would be better? Thanks.
There was a problem hiding this comment.
@ianna - v8 does not exist for ge11, v7 is the final geometry for it. for ge21, v8 is only a temporary geometry we need for our studies, while v7 is the baseline, so it is better to go with v7 for the moment. when we have the final geometry for ge21 we will move to that. for me0, instead, v8 is an already improved version wrt the one present in the PhaseII folder. After this PR we will clean up a bit the old geometries, and organize the remaining files in folders with more explanatory names.
|
+1 |
cmsbuild
added
geometry-approved
fully-signed
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
|
@cmsbuild Please test |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
@davidlange6 I tried to correct the files but I do not see the changes get updated. Is it because of the status? |
|
this pr was merged already, so you need to make a new one instead of updating this one
|
No description provided.