Default initialize PTrajectoryStateOnDet members #13928

davidlt · 2016-04-05T07:43:50Z

GCC 6.0.0 (r234661) we might create PTrajectoryStateOnDet without
initialized members. The patch adds the defaults which later can be
modified by member initializer list in ctor.

RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[10]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[11]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[12]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[13]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[14]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[1]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[2]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[3]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[4]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[5]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[6]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[7]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[8]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[9]' may be used uninitialized in this function [-Werror=maybe-uninitialized]
RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::thePt' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

GCC 6.0.0 (r234661) we might create PTrajectoryStateOnDet without initialized members. The patch adds the defaults which later can be modified by member initializer list in ctor. RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[10]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[11]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[12]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[13]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[14]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[1]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[2]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[3]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[4]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[5]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[6]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[7]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[8]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::theLocalErrors[9]' may be used uninitialized in this function [-Werror=maybe-uninitialized] RecoMuon/StandAloneTrackFinder/src/StandAloneTrajectoryBuilder.cc:282:20: error: 'seedVoid.TrajectorySeed::tsos_.PTrajectoryStateOnDet::thePt' may be used uninitialized in this function [-Werror=maybe-uninitialized] Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>

cmsbuild · 2016-04-05T07:44:12Z

A new Pull Request was created by @davidlt for CMSSW_8_1_X.

It involves the following packages:

DataFormats/TrajectoryState

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @gpetruc, @VinInn this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-04-05T12:11:38Z

@cmsbuild please test

cmsbuild · 2016-04-05T12:12:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12173/console

cmsbuild · 2016-04-05T14:07:04Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-04-05T14:07:32Z

-1
Tested at: ebe1937
I found an error when building:

@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsBeamSpot.so
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-04-1100/src/L1Trigger/CSCTrackFinder/interface/CSCTFSPCoreLogic.h:10:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-04-1100/src/L1Trigger/CSCTrackFinder/interface/CSCTFSectorProcessor.h:20,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-04-1100/src/L1Trigger/CSCTrackFinder/src/CSCTFSectorProcessor.cc:1:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-04-1100/poison/L1Trigger/CSCTrackFinder/src/core_2010_01_22/vpp_generated.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-04-1100/src/L1Trigger/CSCTrackFinder/interface/CSCTFSPCoreLogic.h:11:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-04-1100/src/L1Trigger/CSCTrackFinder/interface/CSCTFSectorProcessor.h:20,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-04-1100/src/L1Trigger/CSCTrackFinder/src/CSCTFSectorProcessor.cc:1:

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12173/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6eb160c
e7693de
bd318d6
ae80dc1
a1b87ee
a1a7545
8e18df4
11c7a67
2c103d5
40cddb8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12173/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12173/git-merge-result

slava77 · 2016-04-05T14:17:47Z

@cmsbuild please test
only shared_ptr is in the way now.
This PR could have been made in an existing IB, otherwise test availability blocks integration by at least half a day.

cmsbuild · 2016-04-05T14:18:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12176/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12367/console

cmsbuild · 2016-04-05T19:59:16Z

-1

Tested at: ebe1937
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12176/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6eb160c
e7693de
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12176/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12176/git-merge-result

cmsbuild · 2016-04-05T20:58:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12176/summary.html

davidlt · 2016-04-10T21:20:41Z

ping^1

davidlt · 2016-04-13T21:35:05Z

ping^2

Are there any objections for the default values?

cmsbuild · 2016-04-14T15:53:46Z

-1

Tested at: ebe1937
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12367/summary.html
'List

cmsbuild · 2016-04-14T17:17:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13928/12367/summary.html

cvuosalo · 2016-04-14T19:18:12Z

+1

For #13928 ebe1937

Initialzing PTrajectoryStateOnDet members that had been left uninitialized. There should be no change in monitored quantities.

The code fix is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-04-13-2300 show no significant differences, as expected.

cmsbuild · 2016-04-14T19:18:34Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 5, 2016

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 5, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2016

cmsbuild added comparison-notrun and removed comparison-pending labels Apr 5, 2016

cmsbuild added tests-rejected comparison-pending and removed comparison-notrun tests-started labels Apr 5, 2016

cmsbuild added tests-pending and removed tests-rejected labels Apr 5, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2016

cmsbuild added tests-rejected and removed tests-started labels Apr 5, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 5, 2016

cmsbuild added comparison-pending and removed comparison-available labels Apr 14, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 14, 2016

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Apr 14, 2016

davidlange6 merged commit 157f047 into cms-sw:CMSSW_8_1_X Apr 14, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Default initialize PTrajectoryStateOnDet members #13928

Default initialize PTrajectoryStateOnDet members #13928

davidlt commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

slava77 commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

slava77 commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

davidlt commented Apr 10, 2016

davidlt commented Apr 13, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cvuosalo commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

Default initialize PTrajectoryStateOnDet members #13928

Default initialize PTrajectoryStateOnDet members #13928

Conversation

davidlt commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

slava77 commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

slava77 commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

cmsbuild commented Apr 5, 2016

davidlt commented Apr 10, 2016

davidlt commented Apr 13, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cvuosalo commented Apr 14, 2016

cmsbuild commented Apr 14, 2016