Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluation of function arguments for FormulaEvaluator #13937

Conversation

Dr15Jones
Copy link
Contributor

The FormulaEvaluator was not using the proper evaluator for the argument
passed to a function if the argument was a complex expression.
Added unit tests for the failing cases.

The FormulaEvaluator was not using the proper evaluator for the argument
passed to a function if the argument was a complex expression.
Added unit tests for the failing cases.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

CommonTools/Utils

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

This is a proper backport of #13890

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12177/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

@slava77
Copy link
Contributor

slava77 commented Apr 7, 2016

@cmsbuild please test
most of the comparison jobs didn't complete the last time (probably due to some file copy failures)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12219/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@slava77
Copy link
Contributor

slava77 commented Apr 7, 2016

+1

for #13937 bf61588

@davidlange6 davidlange6 merged commit 1c34f76 into cms-sw:CMSSW_8_0_X Apr 14, 2016
@Dr15Jones Dr15Jones deleted the fixArgEvaluationInFormulaEvaluator_8_0 branch May 13, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants