SpeedUp ParticleFlow for HLT

[VinInn]

Technical mods to ParticleFlow (and some core classes) to speedup creation for PFRecHIt and PFClusters.
Most of it is trivial.
I did not observe any regression on TTBAR PU35 reco.
Includes contribution by @lgray

added major speedup in ES geometry and EcalRecHit creation

@lgray , @fwyzard

p.s. shrink_to_fit is still calling RefCore copy constructor instead of moving as it should....

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_1_X.

It involves the following packages:

CommonTools/Utils
DataFormats/Common
DataFormats/ParticleFlowReco
Geometry/EcalAlgo
RecoParticleFlow/PFClusterProducer

@smuzaffar, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @wmtan, @makortel, @rafaellopesdesa, @wddgit, @lgray, @argiro, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12209/console

[Dr15Jones]

+1

[cmsbuild]

Pull request #13959 was updated. @smuzaffar, @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[VinInn]

Let me stress that I am not here to put PF code in line with CMSSW standards.
Please try to find and appoint proper person-power to maintain (and optimize) such a critical component of CMS data processing and physics analysis

[cmsbuild]

-1

Tested at: 5d87998
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13959/12300/summary.html
'List

[VinInn]

can we get rid of this runtestTqafTopEventSelection ???

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13959/12300/summary.html

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12331/console

[cmsbuild]

-1

Tested at: 99a4c72
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13959/12331/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ccc64b0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13959/12331/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13959/12331/git-merge-result

'List

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13959/12331/summary.html

[slava77]

+1

for #13959 99a4c72

• changes in the code are in line with the goal: to speedup PF without regressions
• jenkins tests pass and comparisons with baseline show no differences
• the last commits since 38c7739 should introduce no differences run time; see comments on higher stat tests in SpeedUp ParticleFlow for HLT #13959 (comment)

[VinInn]

I am sorry with all those who have already signed once, one more signature of yours is requested.
Thanks.

[Dr15Jones]

+1