Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Set Photon ID/vertex information for PFlow selected photons. #1396

Merged
merged 2 commits into from Nov 18, 2013

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Nov 9, 2013

Set mva value to one as well as primary vertex for photons selected by PFlow.

Shouldn't have an effect on gedPhotons, only changes plots that analyze directly the particleFlow:photons collection.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2013

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X.

Bugfix: Set Photon ID/vertex information for PFlow selected photons.

It involves the following packages:

RecoParticleFlow/PFProducer

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2013

+1

Tested in CMSSW_7_0_X_2013-11-14-0200 in a combination with

Normal mode:

  • increased rate of errors in _logErrorHarvester: in 202.0 18.0 and 38.0
    • e.g. in 202.0: 1 -> 4 of
      %MSG-w PFEGammaAlgo::mergeROsByAnyLink: PFEGammaProducer:particleFlowEGamma
      Encountered the known GSF-SC splitting bug in PFBlockAlgo! We should really fix this!
  • minor variations in the ged photons and electrons and in egamma superclusters, consistent with changes in brem->cluster asociation.
  • large drop of number of ged electrons reconstructed from high-pt muons (expected bugfix)
  • mva values in ged electrons are now filled (only visible in the fwlite script)

GED mode:

  • large drop of electrons reconstructed from high-pt muons (expected bugfix)
  • (connected to above) tau validation plots with muon rejection are now ~100% efficient (as in the original taus)
  • mva values for the electrons are now filled and show up in DQM plots as well

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 18, 2013
Reco Bugfix -- Set Photon ID/vertex information for PFlow selected photons.
@ktf ktf merged commit bc4bd34 into cms-sw:CMSSW_7_0_X Nov 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants