Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwinMux unpacker updates according to new firmware version (v12) #13964

Merged
merged 2 commits into from Apr 14, 2016

Conversation

jpazzini
Copy link

@jpazzini jpazzini commented Apr 6, 2016

Updated the decoding of the packed data according to new TwinMux firmware version (v12).
Removed possibility to pass the bc0 bit in favour of the MB3_phiBending information.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2016

A new Pull Request was created by @jpazzini for CMSSW_8_0_X.

It involves the following packages:

EventFilter/L1TXRawToDigi

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@jpazzini
Copy link
Author

jpazzini commented Apr 7, 2016

please consider this for an urgent approval, as it will be needed for the DT subsystem in Global Runs

@deguio
Copy link
Contributor

deguio commented Apr 12, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12318/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@jpazzini
Copy link
Author

test succeeded, please consider to merge this asap

@mulhearn
Copy link
Contributor

+1

@mulhearn
Copy link
Contributor

Is there an 81X version of this PR?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a3da602 into cms-sw:CMSSW_8_0_X Apr 14, 2016
@jpazzini
Copy link
Author

@mulhearn no, there is no 81X version of this PR; should I open one or is it going to be automatically propagated from 80X -> 81X?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants