Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move L1Trigger/CSCTrackFinder/src/core_ files to external package" #13974

Merged

Conversation

davidlange6
Copy link
Contributor

Reverts #13866

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/CSCTrackFinder

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@smuzaffar
Copy link
Contributor

Do not revert it now. I think I have a fix which fixes workflow 27. I am testing it locally by building full release.

@davidlange6
Copy link
Contributor Author

causing memory corruption in the release it seems

@davidlange6 davidlange6 merged commit d8e6aac into CMSSW_8_1_X Apr 7, 2016
@davidlt
Copy link
Contributor

davidlt commented Apr 7, 2016

The easiest solution is to remove all the hacks and just do e.g., std::getenv("CMSSW_RELEASE_BASE") + "/external/" + std::getenv("SCRAM_ARCH") + "/data/" + L1Trigger/CSCTrackFinder/data/core_2014_05_15/comp_dphi_8.dat" or similar in the external.

@smuzaffar
Copy link
Contributor

@davidlt , I like the idea

@davidlange6
Copy link
Contributor Author

ah - sorry - i missed your comments
we can just revert the revert....

@smuzaffar
Copy link
Contributor

no need to re-revert. I just wanted that revert does not go in the history of git.
Anyway, as it is now in so just leave it there for next IB. It will give me more time for tests :-)

@smuzaffar smuzaffar deleted the revert-13866-L1Trigger-CSCTrackFinder-to-external branch October 19, 2016 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants