Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of puppi changes from 80X to 76X #13975

Merged
merged 1 commit into from Apr 19, 2016

Conversation

violatingcp
Copy link
Contributor

These are changes to the puppi code in 80X. This includes :

  1. Addition of PuppiPhoton (with all fixes from 80X)
  2. Addition of Puppi Jet corrector flags
  3. Code to build puppi MET collections for MiniAOD Puppi MET

This does not include :

  1. 80X tune of puppi (with loosened forward particle cuts)
  2. Updaed MiniAOD MET reconstruction code for Puppi

The 2 updates below will come with a bigger pull request that also includes the addition of the MET Uncertainties code.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

A new Pull Request was created by @violatingcp (Philip Harris) for CMSSW_7_6_X.

It involves the following packages:

CommonTools/PileupAlgos
JetMETCorrections/Configuration
PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 7, 2016

@cmsbuild please test
IIUC, this changes miniAOD
I'm not aware of a solid plan so far to allow updates that change miniAOD in 76X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12228/console

@mariadalfonso
Copy link
Contributor

@slava77 .
These files here are only partial backport of the 80X. These alone would not change the miniAOD since are not inserted in any sequence (miniOAD production, miniAOD-->miniAOD). But better to have in the release than flying around.

For now the 76X backport (met side) include all these in a separate private recipe
CMSSW_7_6_X...cms-met:metTool76X
that I'm trying to slim.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@slava77
Copy link
Contributor

slava77 commented Apr 18, 2016

@cmsbuild please test
something happened to the original comparisons (none show up in #13975 (comment))

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12446/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 18, 2016

+1

for #13975 5106c33

@davidlange6 davidlange6 merged commit d58b6e5 into cms-sw:CMSSW_7_6_X Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants