Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cacheIdentifier to Run, Lumi and Event #1398

Merged
merged 2 commits into from Nov 11, 2013
Merged

Added cacheIdentifier to Run, Lumi and Event #1398

merged 2 commits into from Nov 11, 2013

Conversation

Dr15Jones
Copy link
Contributor

Added a cacheIdentifier in order to make it easier to identify when an item cached from a Principal has changed. This has been used by the EventSetup system from the beginning.

@Dr15Jones
Added cacheIdentifier to Run, Lumi and Event
f263a85 
Added a cacheIdentifier in order to make it easier to identify when an item cached from a Principal has changed. This has been used by the EventSetup system from the beginning.
@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@Dr15Jones
Properly handle setting cacheIdentifier when there are multiple Run,L…
cc5d212 
…umi,Event

We now use a std::atomic static to uniquely give cacheIdentifiers to all Runs, Lumis and Events in a job.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Added cacheIdentifier to Run, Lumi and Event

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

Pull request #1398 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Nov 11, 2013

Checked in:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/1273/

approving.

ktf added a commit that referenced this pull request Nov 11, 2013
@ktf
Merge pull request #1398 from Dr15Jones/addCacheIdentifier
9a81074 
Multithreaded framework -- Added cacheIdentifier to Run, Lumi and Event
@ktf ktf merged commit 9a81074 into cms-sw:CMSSW_7_0_X Nov 11, 2013
@Dr15Jones Dr15Jones deleted the addCacheIdentifier branch November 14, 2013 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed tests-pending
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @ktf