Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCL SiPixel Alignment: integration of quality checks on payload and DQM module #13984

Closed
wants to merge 12 commits into from

Conversation

cerminar
Copy link
Contributor

@cerminar cerminar commented Apr 7, 2016

This PR modifies only the PCL sequences for the alignment of the Pixel large structures.
It integrates the needed checks for the creation of the payload and the DQM module to monitor the movements of the alignables.

This is needed to start testing the new workflow in production environment.

This is equivalent to PR #13983 for 81X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

A new Pull Request was created by @cerminar for CMSSW_8_1_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm

@cmsbuild, @mmusich, @franzoni, @cerminar, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Apr 7, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12238/console


int det = -1;

if (alignable >= 60 && alignable <= 69) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghellwig for the sake of curiosity how is the millepede internal labeling going to behave with the phase-I geometry?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich I think, as long as the number of alignables does not exceed 700000 we are fine:

https://github.com/cerminar/cmssw/blob/PCLDQMPlots_80X_v2/Alignment/MillePedeAlignmentAlgorithm/src/PedeLabelerBase.cc#L22

Haven't checked it, though.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2016

@cerminar cerminar closed this Apr 8, 2016
@cerminar
Copy link
Contributor Author

cerminar commented Apr 8, 2016

Ops, this PR was obviously meant for 80X since there is already one in 81X, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants