Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-gem14 Update the forward muon definition in 2023 Geometry scenario #13996

Merged
merged 1 commit into from Apr 11, 2016

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Apr 8, 2016

Correct the shortcoming in PR13916 (etaMax file was missing in PR13916)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2016

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@bsunanda
Copy link
Contributor Author

bsunanda commented Apr 8, 2016

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12260/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2016

@ianna
Copy link
Contributor

ianna commented Apr 11, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

Thanks @bsunanda - but could you change the title of this PR to be more descriptive. Thanks

@bsunanda bsunanda changed the title bsunanda:Phase2-gem14 Correct the shortcoming in PR13916 bsunanda:Phase2-gem14 Update the forward muon definition in 2023 Geometry scenario Apr 11, 2016
@bsunanda
Copy link
Contributor Author

@davidlange6 Changed the title

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 92c770d into cms-sw:CMSSW_8_1_X Apr 11, 2016
@boudoul
Copy link
Contributor

boudoul commented Apr 12, 2016

Hi @bsunanda ,
I'm trying to built the phase2 WFs (2023dev and 2023LReco) but it seems that this PR causes problems in the DIGI step for the phase 2 geometries -I put here (*) a snippet of the traceback - could you have a look using this recipe ?

git cms-merge-topic 13923
scramv1 b -j 8
runTheMatrix.py -l 10600

Adding @kpedro88 FYI
Many Thanks

()
#5 0x00007fa284763594 in DDValue::doubles() const () from /cvmfs/cms-ib.cern.ch/2016-16/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-04-10-0000/lib/slc6_amd64_gcc530/libDetectorDescriptionCore
.so
#6 0x00007fa27cc21c40 in RPCGeometryBuilderFromDDD::buildGeometry(DDFilteredView&, MuonDDDConstants const&) () from /cvmfs/cms-ib.cern.ch/2016-16/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-0
4-10-0000/lib/slc6_amd64_gcc530/libGeometryRPCGeometryBuilder.so
#7 0x00007fa27cc22bcc in RPCGeometryBuilderFromDDD::build(DDCompactView const
, MuonDDDConstants const&) () from /cvmfs/cms-ib.cern.ch/2016-16/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-04-1
0-0000/lib/slc6_amd64_gcc530/libGeometryRPCGeometryBuilder.so
#8 0x00007fa27cf520bc in RPCGeometryESModule::produce(MuonGeometryRecord const&) () from /cvmfs/cms-ib.cern.ch/2016-16/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-04-10-0000/lib/slc6_amd64_gc
c530/pluginRPCGeometryESModule.so
#9 0x00007fa27cf53f8c in edm::eventsetup::CallbackProxy<edm::eventsetup::Callback<RPCGeometryESModule, std::shared_ptr, MuonGeometryRecord, edm::eventsetup::CallbackSimpleDecorato
r >, MuonGeometryRecord, std::shared_ptr >::getImpl(edm::eventsetup::EventSetupRecord const&, edm::eventsetup::DataKey const&) () from /cvmfs/cms-ib.cern.ch/201
6-16/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-04-10-0000/lib/slc6_amd64_gcc530/pluginRPCGeometryESModule.so
#10 0x00007fa2972eb7df in edm::eventsetup::DataProxy::get(edm::eventsetup::EventSetupRecord const&, edm::eventsetup::DataKey const&, bool) const () from /cvmfs/cms-ib.cern.ch/2016-16/slc6_amd64
gcc530/cms/cmssw/CMSSW_8_1_X_2016-04-10-0000/lib/slc6_amd64_gcc530/libFWCoreFramework.so
#11 0x00007fa2972e4d0b in edm::eventsetup::EventSetupRecord::getFromProxy(edm::eventsetup::DataKey const&, edm::eventsetup::ComponentDescription const
&, bool) const () from /cvmfs/cms-ib.cern.
ch/2016-16/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-04-10-0000/lib/slc6_amd64_gcc530/libFWCoreFramework.so
#12 0x00007fa2708b64b2 in RPCTechnicalTrigger::beginRun(edm::Run const&, edm::EventSetup const&) () from /cvmfs/cms-ib.cern.ch/2016-16/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-04-10-0000/li
b/slc6_amd64_gcc530/pluginL1TriggerRPCTechnicalTrigger.so
#13 0x00007fa2972a899b in edm::EDProducer::doBeginRun(edm::RunPrincipal const&, edm::EventSetup const&, edm::ModuleCallingContext const_) () from /cvmfs/cms-ib.cern.ch/2016-16/slc6_amd64_gcc530
/cms/cmssw/CMSSW_8_1_X_2016-04-10-0000/lib/slc6_amd64_gcc530/libFWCoreFramework.so

@kpedro88
Copy link
Contributor

@boudoul @bsunanda - There was some previous discussion about the Phase2 muon geometry here: #13992 (diff)

If it's still causing problems, needs to be sorted out ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants