Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OwnVector should use unique_ptr, not auto_ptr #14009

Merged
merged 1 commit into from Apr 12, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Apr 10, 2016

auto_ptr is deprecated in C++, but is still used in the framework in three places. One of these is OwnVector, which also supports unique_ptr. This PR changes every user of OwnVector that uses auto_ptr to use unique_ptr instead. and removes support for auto_ptr in OwnVector. It also uses std::make_unique when appropriate.
This PR also changes a very small number of auto_ptr's to unique_ptr's unrelated to OwnVector in files that were modified anyway.
In cases where auto_ptr was passed by reference (a bad practice), the code was modified to pass unique_ptr by value in those cases where ownership is being transferred, and to pass a bare pointer (get()) in cases where ownership is not transferred,
This PR is totally technical.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

CommonTools/CandAlgos
CommonTools/UtilAlgos
DataFormats/Candidate
DataFormats/Common
DataFormats/PatCandidates
FastSimulation/TrackingRecHitProducer
MuonAnalysis/MuonAssociators
PhysicsTools/PatAlgos
PhysicsTools/RecoAlgos

@smuzaffar, @civanch, @Dr15Jones, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @abbiendi, @rappoccio, @Martin-Grunewald, @mmarionncern, @battibass, @ahinzmann, @acaudron, @jhgoh, @jdolen, @ferencek, @trocino, @bellan, @nhanvtran, @schoef, @imarches, @wddgit, @makortel, @gpetruc, @matt-komm, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@wmtan
Copy link
Contributor Author

wmtan commented Apr 10, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12272/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 225e147
I found errors in the following unit tests:

---> test runtestTqafTopEventSelection had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14009/12272/summary.html

@cmsbuild
Copy link
Contributor

@wmtan
Copy link
Contributor Author

wmtan commented Apr 11, 2016

@cmsbuild @davidlange6 Again, this unit test fails in the base IB and has nothing to do with this PR.

@Dr15Jones
Copy link
Contributor

+1

@davidlange6 davidlange6 merged commit cdf09f0 into cms-sw:CMSSW_8_1_X Apr 12, 2016
@wmtan wmtan deleted the UseUniquePtrInOwnVector branch May 26, 2016 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants