Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed need for UpdaterService in MuonDetLayerMeasurements #1402

Conversation

Dr15Jones
Copy link
Contributor

The UpdaterService is not thread-safe and therefore must be removed. MuonDetLayerMeasurments was the only user of UpdaterService in production jobs. The use of the UpdaterService was replaced with the new cacheIdentifier() information from the edm::Event. The cacheIdentifier() can be used to quickly check to see if an edm::Event has changed since the last call to a method.

The UpdaterService is not thread-safe and therefore must be removed. MuonDetLayerMeasurments was the only user of UpdaterService in production jobs. The use of the UpdaterService was replaced with the new cacheIdentifier() information from the edm::Event. The cacheIdentifier() can be used to quickly check to see if an edm::Event has changed since the last call to a method.
@Dr15Jones
Copy link
Contributor Author

@ktf Giulio, why hasn't this been assigned to a L2?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Removed need for UpdaterService in MuonDetLayerMeasurements

It involves the following packages:

RecoMuon/MeasurementDet

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Nov 14, 2013

glitch.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Nov 14, 2013

+1
Tested d3868de in CMSSW_7_0_X_2013-11-13-0200-1402
No change in reco as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 14, 2013
…etLayerMeasurements

Multithreading fixes -- Removed need for UpdaterService in MuonDetLayerMeasurements
@ktf ktf merged commit 18bbc2e into cms-sw:CMSSW_7_0_X Nov 14, 2013
@Dr15Jones Dr15Jones deleted the removeUpdaterServiceFromMuonDetLayerMeasurements branch November 14, 2013 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants