Phase2-hgx48 Introduce fiducial cut off for HGC SimHit

[bsunanda]

No description provided.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12290/console

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

CondFormats/GeometryObjects
Geometry/HGCalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @franzoni, @cerminar, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

+1
Tested at: 74bef2c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14020/12290/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14020/12290/summary.html

[ianna]

+1

[civanch]

+1

[lgray]

Hey everyone, I would like to take a quick look at this PR before we merge it.
Logic looks fine but just want to make sure there is little degradation in time.
This function gets called a lot and we just put a two sqrts and a ton of multiplies inside of it.

@cseez @kpedro88 @vandreev11

[lgray]

It is a negligible performance penalty compared to other issues in GEANT at the moment.
We can come back to it later if it pops back up in terms of slowdown.

[bsunanda]

@mmusich @ggovi please sign this

[mmusich]

+1
there are only only minimal changes in CondFormats/GeometryObjects
@ggovi should give a look and tell if it is ok.

[bsunanda]

@ggovi Could you please sign this PR

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar