Fix getByLabelWithoutRegistration (81X). #14061

ndaci · 2016-04-14T09:19:39Z

This is an 81X version of #13041 that was created by @jingyucms.
The changes fix a segmentation fault.
The fix is urgently needed by the TSG/STEAM subgroup.

An 80X backport version will follow.

cmsbuild · 2016-04-14T09:21:48Z

A new Pull Request was created by @ndaci for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/GenFilters
SimGeneral/MixingModule

@civanch, @covarell, @mdhildreth, @cmsbuild, @thuer, @govoni, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

civanch · 2016-04-14T10:04:13Z

Modifications are fine but in non-modified line 223 std::auto_ptr is used. Should replacement of std::auto_ptr be done in this PR or in the next one?

ndaci · 2016-04-14T10:07:03Z

Why should "std::auto_ptr" be replaced? And by what?
Thanks in advance for the clarification.

civanch · 2016-04-14T15:23:30Z

please test
In new compilers std::auto_ptr should be replaced by std::unique_ptr, if not possible then by std::shared_ptr

I would guess the fix should be done in a separate PR.

cmsbuild · 2016-04-14T15:23:49Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12380/console

davidlt · 2016-04-14T15:43:32Z

@ndaci because it's deprecated by C++ standards since C++11.

cmsbuild · 2016-04-14T15:56:37Z

-1
Tested at: d19c9e6
When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 14-Apr-2016 17:31:41 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 14-Apr-2016 17:31:41 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 14-Apr-2016 17:31:47 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 14-Apr-2016 17:32:33 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

10021.0 step2

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
----- Begin Fatal Exception 14-Apr-2016 17:33:12 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 14-Apr-2016 17:36:33 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 14-Apr-2016 17:38:59 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 14-Apr-2016 17:39:19 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 14-Apr-2016 17:41:22 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
----- Begin Fatal Exception 14-Apr-2016 17:41:46 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 14-Apr-2016 17:41:48 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
MissingParameter: Parameter 'HepMCProductLabel' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14061/12380/summary.html
'List

civanch · 2016-04-14T16:26:54Z

@ndaci , the line 222 of MixingModule.cc is not needed at all, having such consumes within a loop is not a correct thing, in the constructor there is a place where HepMCProduct consumes declaration is set.

ndaci · 2016-04-14T16:29:37Z

Thanks for the tests and interpretations.
Ok, should I simply remove the incriminated line ?

civanch · 2016-04-14T16:32:41Z

I think so.

cmsbuild · 2016-04-14T16:35:54Z

Pull request #14061 was updated. @cmsbuild, @covarell, @govoni, @thuer, @davidlange6 can you please check and sign again.

civanch · 2016-04-14T16:36:41Z

please test

cmsbuild · 2016-04-14T16:36:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12385/console

cmsbuild · 2016-04-14T18:28:16Z

+1
Tested at: 7abe216
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14061/12385/summary.html

cmsbuild · 2016-04-14T19:23:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14061/12385/summary.html

tobias-pook · 2016-04-29T12:36:38Z

When do you plan the backport ? We plan to produce n-tuples for some groups with the production version 8_0_X soon and this fix is needed to include gen filter results. We otherwise need to merge topic from a user fork.

ndaci · 2016-04-29T13:51:28Z

The backport PR #14064 was open simultaneously. I got no news there for now.

fwyzard · 2017-01-17T15:47:30Z

@ndaci , the line 222 of MixingModule.cc is not needed at all, having such consumes within a loop is not a correct thing, in the constructor there is a place where HepMCProduct consumes declaration is set.

Looks like the consumes was actually needed... @ndaci , can you make a PR for 8.0.x, 8.1.x and 9.0.x that adds it back ?

By the way, tje comment about it being inside a loop is just moot - if the module is configured with multiple input collections, consumes has to be called for all of them.

Fix getByLabelWithoutRegistration (81X).

d19c9e6

ndaci mentioned this pull request Apr 14, 2016

Fix getByLabelWithoutRegistration (80X). #14063

Closed

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 14, 2016

cmsbuild added simulation-pending generators-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 14, 2016

ndaci mentioned this pull request Apr 14, 2016

Fix getByLabelWithoutRegistration (80X). #14064

Merged

cmsbuild added tests-started and removed tests-pending labels Apr 14, 2016

cmsbuild added tests-rejected and removed tests-started labels Apr 14, 2016

Remove harmful consumes call inside of a loop.

7abe216

cmsbuild added tests-pending and removed simulation-pending tests-rejected labels Apr 14, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 14, 2016

cmsbuild added tests-approved and removed tests-started labels Apr 14, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 14, 2016

davidlange6 merged commit 4751015 into cms-sw:CMSSW_8_1_X Apr 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix getByLabelWithoutRegistration (81X). #14061

Fix getByLabelWithoutRegistration (81X). #14061

ndaci commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

civanch commented Apr 14, 2016

ndaci commented Apr 14, 2016

civanch commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

davidlt commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

civanch commented Apr 14, 2016

ndaci commented Apr 14, 2016

civanch commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

civanch commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

tobias-pook commented Apr 29, 2016

ndaci commented Apr 29, 2016

fwyzard commented Jan 17, 2017

Fix getByLabelWithoutRegistration (81X). #14061

Fix getByLabelWithoutRegistration (81X). #14061

Conversation

ndaci commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

civanch commented Apr 14, 2016

ndaci commented Apr 14, 2016

civanch commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

davidlt commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

civanch commented Apr 14, 2016

ndaci commented Apr 14, 2016

civanch commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

civanch commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

tobias-pook commented Apr 29, 2016

ndaci commented Apr 29, 2016

fwyzard commented Jan 17, 2017