Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save L1 stage2 info in offline data tiers (80X) #14068

Merged
merged 3 commits into from Apr 22, 2016

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Apr 14, 2016

80X version of #14051

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_8_0_X.

It involves the following packages:

L1Trigger/Configuration
PhysicsTools/PatAlgos

@cvuosalo, @cmsbuild, @rekovic, @slava77, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @Martin-Grunewald, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 14, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12375/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14068/12375/summary.html

The workflows 1003.0, 1000.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77
Copy link
Contributor

slava77 commented Apr 14, 2016

+1

for #14068 af26b2c

  • changes are in line with the description; the same code change as in Save L1 stage2 info in offline data tiers (81X) #14051
  • jenkins tests pass: comparisons with baseline show no difference as expected; 2017 workflows now contain the stage2 collections on output
    in 10021.0 reco file (10 events of TenMuE_0_200)
-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
      0.0 ->       285.6        286     NEWO   0.05     l1tEtSumBXVector_caloStage2Digis_EtSum_RECO.
      0.0 ->       325.5        326     NEWO   0.05     l1tJetBXVector_caloStage2Digis_Jet_RECO.
      0.0 ->       290.4        290     NEWO   0.05     l1tTauBXVector_caloStage2Digis_Tau_RECO.
      0.0 ->       252.0        252     NEWO   0.04     GlobalExtBlkBXVector_gtStage2Digis__RECO.
      0.0 ->       286.1        286     NEWO   0.05     GlobalAlgBlkBXVector_gtStage2Digis__RECO.
      0.0 ->       438.6        439     NEWO   0.07     l1tMuonBXVector_gmtStage2Digis_Muon_RECO.
      0.0 ->       252.5        252     NEWO   0.04     l1tEGammaBXVector_caloStage2Digis_EGamma_RECO.
-------------------------------------------------------------
   618395 ->      620525       2130             0.3     ALL BRANCHES

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2016

@davidlange6
this could have gone to 805
I tested the 81X version of this change on run2 data with T0 config before signing these PRs

@mulhearn
Copy link
Contributor

+1

@mulhearn
Copy link
Contributor

Thanks for doing this!

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c0fa03a into cms-sw:CMSSW_8_0_X Apr 22, 2016
@gpetruc gpetruc deleted the saveL1Stage2Info-80X branch June 1, 2016 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants