Streamline calling of unscheduled EDProducers #14081
Conversation
When a data product from an unscheduled EDProducer was requested, we used to have UnscheduledProductResolver call a virtual function of Principal to call a virtual function of UnscheduledHandler to trigger looking the Worker which then calls the module. Now we setup to have the UnscheduledProductResolver have direct access to the Worker and therefore invoke it directly without any lookup or extra virtual calls. This refactoring is needed for work to allow asynchronous calling of unscheduled EDProducers.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/src/TriggerResultInserter.cc
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/src/SharedResourcesRegistry.cc
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/interface/WorkerManager.h:10:0,
from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/interface/Schedule.h:66,
from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/src/Schedule.cc:1:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/interface/UnscheduledCallProducer.h:22:55: fatal error: FWCore/Framework/src/UnscheduledAuxiliary.h: No such file or directory
compilation terminated.
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/src/RunPrincipal.cc
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/interface/WorkerManager.h:10:0,
from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/interface/Schedule.h:66,
from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-04-13-2300/src/FWCore/Framework/src/Schedule.cc:1:
you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: 'List |
cmsbuild
added
tests-rejected
comparison-pending
and removed
comparison-notrun
tests-started
labels
These files are needed for the simplification of unscheduled calling.
|
please test |
|
Pull request #14081 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again. |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
When a data product from an unscheduled EDProducer was requested, we used to have UnscheduledProductResolver call a virtual function of Principal to call a virtual function of UnscheduledHandler to trigger looking the Worker which then calls the module. Now we setup to have the UnscheduledProductResolver have direct access to the Worker and therefore invoke it directly without any lookup or extra virtual calls.
This refactoring is needed for work to allow asynchronous calling of unscheduled EDProducers.