Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for emulator match problem and incorrect tower binning. #14090

Merged

Conversation

tanmaymudholkar
Copy link
Contributor

(1) Fixed emulator match problem where, if two adjacent channels were saturated in energy, the emulated and data TP showed a match at two values
(2) Fixed incorrect trigger tower binning because of which emulator matches for TTs in a given TCC would overflow into the next TCC.

(1) Fixed emulator match problem where, if two adjacent channels were saturated in energy, the emulated and data TP showed a match at two values
(2) Fixed incorrect trigger tower binning because of which emulator matches for TTs in a given TCC would overflow into the next TCC.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for CMSSW_8_0_X.

It involves the following packages:

DQM/EcalCommon
DQM/EcalMonitorTasks

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@tanmaymudholkar tanmaymudholkar changed the title Two changes: Fix for emulator match problem and incorrect tower binning. Apr 18, 2016
@deguio
Copy link
Contributor

deguio commented Apr 22, 2016

please test

@deguio
Copy link
Contributor

deguio commented Apr 22, 2016

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12582/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6 davidlange6 merged commit 0a90a7d into cms-sw:CMSSW_8_0_X Apr 26, 2016
@tanmaymudholkar tanmaymudholkar deleted the emul_match_fixes_8_0_X branch June 8, 2016 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants