Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT for L1v4 + GT+ relval + L1 fixes from valgrind (back ports) #14107

Merged
merged 68 commits into from Apr 16, 2016

Conversation

davidlange6
Copy link
Contributor

Merging #13862, #13893, and #13940 + back ports of MC relval updates to 2016 scenarios

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_0_X.

It involves the following packages:

Configuration/AlCa
Configuration/HLT
Configuration/PyReleaseValidation
Configuration/Skimming
Configuration/StandardSequences
HLTrigger/Configuration
HLTrigger/HLTcore
HLTrigger/HLTfilters
L1Trigger/L1TCalorimeter
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonEndCap
Utilities/ReleaseScripts

@perrotta, @smuzaffar, @Dr15Jones, @franzoni, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @srimanob, @cmsbuild, @fwyzard, @mmusich, @hengne, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @geoff-smith, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @wddgit, @tocheng, @jalimena, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12426/console

@@ -556,11 +556,11 @@ def genS(fragment,howMuch):
'--datatier':'GEN-SIM-DIGI-RECO,DQMIO',
'--relval':'27000,3000'},
step1Defaults])
step1FastUpg2015Defaults =merge([{'-s':'GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION:@standardValidation,DQM:@standardDQM',
step1FastUpg2015Defaults =merge([{'-s':'GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,L1Reco,RECO,EI,DIGI2RAW,HLT:@relval25ns,VALIDATION:@standardValidation,DQM:@standardDQM',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 why we don't change the HLT:@relval25ns here for fastsim also to HLT:@relval2016 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I use what is in 81x unless I missed a commit. Let's see what the tests say

On 16 Apr 2016, at 09:00, Hengne Li <notifications@github.commailto:notifications@github.com> wrote:

In Configuration/PyReleaseValidation/python/relval_steps.pyhttps://github.com//pull/14107#discussion_r59963714:

@@ -556,11 +556,11 @@ def genS(fragment,howMuch):
'--datatier':'GEN-SIM-DIGI-RECO,DQMIO',
'--relval':'27000,3000'},
step1Defaults])
-step1FastUpg2015Defaults =merge([{'-s':'GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION:@standardValidation,DQM:@standardDQM',
+step1FastUpg2015Defaults =merge([{'-s':'GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,L1Reco,RECO,EI,DIGI2RAW,HLT:@relval25ns,VALIDATION:@standardValidation,DQM:@standardDQM',

@davidlange6https://github.com/davidlange6 why we don't change the HLT:@relval25ns here for fastsim also to HLT:@relval2016 ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com//pull/14107/files/db3d50025447fb8c16dff5ab467a0b1d7a3add5a#r59963714

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's see what we have from the test. In the corresponding 81x PR #14098 , i changed it to relval2016 too because I see the corresponding era for these fastsim workflows has been changed to Run2_2016 already.

@davidlange6 davidlange6 merged commit fc54ad4 into cms-sw:CMSSW_8_0_X Apr 16, 2016
@cmsbuild
Copy link
Contributor

@hengne
Copy link
Contributor

hengne commented Apr 18, 2016

@davidlange6 Hi David, when will be the next IB built with this PR inside? I am planning to test the relval data workflows implementation with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants