bsunanda:Phase2-hgx50 Validation code for HGCal and in particular geometry validation

[bsunanda]

Close earlier PR for the validation code on a similar topic and reformatted EDAnalyzer to DQMAnalyzer

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12443/console

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

SimDataFormats/ValidationFormats
Validation/Configuration
Validation/HGCalValidation

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

+1
Tested at: 02a5cfd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14115/12443/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14115/12443/summary.html

[slava77]

static analysis reports an issue (not allowed try-catch)
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14115/12443/llvm-analysis/report-b5480a.html#EndPath

[slava77]

+1

for #14115 02a5cfd

• reco is minimally affected: the only (remotely related) modifications are in Validation/Configuration to define hgcalValidation sequence and add a postvalidation hgcalPostProcessor. This is relevant only for phase2 workflows.
• jenkins tests pass

[civanch]

+1

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12449/console

[cmsbuild]

Pull request #14115 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

[cmsbuild]

+1
Tested at: f618471
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14115/12449/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14115/12449/summary.html

[bsunanda]

@civanch @slava77 @deguio Could you please sign this PR

[civanch]

+1

[slava77]

+1

for #14115 f618471

• compared to the last approval, only rather straightforward changes were added to address issues from the static code analysis
  • https://github.com/cms-sw/cmssw/compare/02a5cfd...f6184710bb9c735ec466a8b1d6be5d95c5d51030?w=1
• jenkins tests pass and no changes appear in tested workflows

[deguio]

+1
the code looks fine. the only potential problem I see as soon as this runs centrally, is the amount of bins booked in 2D maps. a tuning/reduction will be needed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar