Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unordered Map Serialization #14121

Merged
merged 1 commit into from Apr 27, 2016

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Apr 18, 2016

  • Add serialization for unordered map

@ianna
Copy link
Contributor Author

ianna commented Apr 18, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12454/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

CondFormats/GeometryObjects
CondFormats/Serialization

@cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ianna
Copy link
Contributor Author

ianna commented Apr 18, 2016

@ggovi - as discussed, here is a schema which requires unordered map serialization. Please, have a look and comment. Thanks.

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor

ggovi commented Apr 18, 2016

@ianna
Indeed we discussed this - but you are modifying an existing CondFormat... We should not do that...

@ianna
Copy link
Contributor Author

ianna commented Apr 18, 2016

@ggovi - I do not think the schema was ever used, it is still under development.

@ggovi
Copy link
Contributor

ggovi commented Apr 18, 2016

@ianna
Ok after a check, there are no payloads stored for this class. we can go ahead with the PR, any payload stored meanwhile will be deleted.

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor

ggovi commented Apr 19, 2016

+1

@mmusich
Copy link
Contributor

mmusich commented Apr 26, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 543cf01 into cms-sw:CMSSW_8_1_X Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants