Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition loading in Castor DQM online client #14193

Merged

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Apr 21, 2016

The Castor DQM online client in DQM/Integration/python/clients/castor_dqm_sourceclient-live_cfg.py should load all the conditions from the online GT provided by DQM configuration, and eventually customise them, not just define the Castor records on their own.

This commit reverts 099ad01 which is a regression, as it reintroduces the bug fixed when testing in the online playback by commit 6943411#diff-3d9d457e24541d87ac089a37cc36fd1f

…_dqm_sourceclient-live_cfg.py: it should load all the conditions from the online GT provided by DQM configuration, and eventually customise them, not just define the Castor records on their own.

This commit reverts cms-sw@099ad01
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_8_1_X.

It involves the following packages:

DQM/Integration

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Apr 22, 2016

please test

@deguio
Copy link
Contributor

deguio commented Apr 22, 2016

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12595/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a82fdfa into cms-sw:CMSSW_8_1_X Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants