Fixed non-const static for FastSimulation/L1CaloTriggerProducer/

[nclopezo]

No description provided.

[cmsbuild]

A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_0_X.

Fixed non-const static for FastSimulation/L1CaloTriggerProducer/

It involves the following packages:

FastSimulation/L1CaloTriggerProducer

@cmsbuild, @nclopezo, @giamman, @lveldere can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[Dr15Jones]

I suggest changing this to

  static const std::vector<unsigned> vetoPatterns = { 5, 7, 9, 10,11,13,14,15};
    vetoPatterns.push_back(5);
    vetoPatterns.push_back(7);
    vetoPatterns.push_back(9);
    vetoPatterns.push_back(10);
    vetoPatterns.push_back(11);
    vetoPatterns.push_back(13);
    vetoPatterns.push_back(14);
    vetoPatterns.push_back(15);
  };

Where you actually move the declaration of vetoPatterns to be just before the function which uses it. This will make it a file scope static which the compiler can create and initialize outside the body of the function.

[Dr15Jones]

On the previous comment, remove the vetoPatterns.push_back(..); lines. Those were a cut-n-paste error. All you want is

static const std::vector<unsigned> vetoPatterns = { 5, 7, 9, 10,11,13,14,15};

[nclopezo]

is it ok if I do this?

static const std::vector<unsigned> vetoPatterns = { 5, 7, 9, 10,11,13,14,15};

  for(std::vector<unsigned>::const_iterator i = vetoPatterns.begin();
      i != vetoPatterns.end();  i++) {
....

[Dr15Jones]

That will work. However a function local static requires the compiler to add a lot of overhead code in order to initialize the value in a thread-safe manner. By moving the 'static const' outside of the function you avoid all that extra work.

[cmsbuild]

Pull request #1421 was updated. @cmsbuild, @nclopezo, @giamman, @lveldere can you please check and sign again.

[giamman]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1337/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[ktf]

@nclopezo: Notice that in C++11 you can use the "auto" keyword in place of the iterators.