Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards first hlt menu for 2016 (80X) #14227

Conversation

Martin-Grunewald
Copy link
Contributor

Towards first hlt menu for 2016 (80X)
Backport of #14226

mtosi and others added 30 commits March 9, 2016 13:44
(1) Fixed emulator match problem where, if two adjacent channels were saturated in energy, the emulated and data TP showed a match at two values
(2) Fixed incorrect trigger tower binning because of which emulator matches for TTs in a given TCC would overflow into the next TCC.
Using erase()/insert() causes massive overhead, much faster with at()
This particularly affects the L1TCaloLayer1 module.
@cmsbuild
Copy link
Contributor

Pull request #14227 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

Need to wait until #14281 (GTs) is integrated!

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

@perrotta
Copy link
Contributor

perrotta commented May 2, 2016

Please do not waste your time inspecting this PR: this is meant to be signed by HLT only, and it actually only updates 19 files in our package. However, the commands I normally use to rebase it (to CMSSW_8_0_6, in this case) fail: just wait that I understand why, and the request of your signature will disappear from here...

@perrotta
Copy link
Contributor

perrotta commented May 2, 2016

Please @Martin-Grunewald : close, as it is replaced by #14325

@perrotta
Copy link
Contributor

perrotta commented May 2, 2016

-1

@perrotta perrotta deleted the towardsFirstHltMenuFor2016_80X branch May 30, 2016 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment