Input files for offline TkCommissioner tool, 81X #14233

vdutta · 2016-04-25T12:20:37Z

Production of input root files for the offline TkCommissioner tool. These files contain the information from the tracker maps produced for offline SiStrip DQM indexed by detId for a given run and can be used to get a better understanding of SiStrip DQM issues at the module level. This is the 81X version of #14232.

…e TkCommissioner for better understanding SiStrip DQM issues

cmsbuild · 2016-04-25T12:20:59Z

A new Pull Request was created by @vdutta (Valentina Dutta) for CMSSW_8_1_X.

It involves the following packages:

DQM/SiStripMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

dmitrijus · 2016-05-10T12:19:46Z

DQM/SiStripMonitorClient/src/SiStripOfflineDQM.cc

  inputFileName_           = configPar_.getUntrackedParameter<std::string>("InputFileName","");
  outputFileName_          = configPar_.getUntrackedParameter<std::string>("OutputFileName","");
  globalStatusFilling_     = configPar_.getUntrackedParameter<int>("GlobalStatusFilling", 1);
  printFaultyModuleList_   = configPar_.getUntrackedParameter<bool>("PrintFaultyModuleList", false);

  nEvents_  = 0;
+
+  tkinfoTree_ = 0;


use nullptr, for clarity :)

dmitrijus · 2016-05-10T12:24:37Z

+1
I've added a few comments to the commits

cmsbuild · 2016-05-10T12:24:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12898/console

cmsbuild · 2016-05-10T12:24:57Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

dmitrijus · 2016-05-10T12:26:31Z

DQM/SiStripMonitorClient/src/SiStripOfflineDQM.cc


 	for(std::vector<edm::ParameterSet>::iterator it = tkMapOptions.begin(); it != tkMapOptions.end(); ++it) {
 	  edm::ParameterSet tkMapPSet = *it;
 	  std::string map_type = it->getUntrackedParameter<std::string>("mapName","");
+          map_names.push_back(map_type);


a mix of tabs and spaces for indentation

cmsbuild · 2016-05-10T14:46:45Z

+1
Tested at: 698a0d6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14233/12898/summary.html

cmsbuild · 2016-05-10T16:04:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14233/12898/summary.html

davidlange6 · 2016-05-12T07:54:49Z

DQM/SiStripMonitorClient/src/SiStripTrackerMapCreator.cc

+    uint32_t nHists = map_names.size();
+
+    for(uint32_t ih = 0; ih < nHists; ++ih) {
+      tkHMaps.push_back(new TkHistoMap());


how are these pointers deleted
@vdutta

fioriNTU · 2016-05-17T14:24:57Z

@vdutta can you please try to clarify what David asks, we need this PR merged asap

cmsbuild · 2016-05-17T16:48:48Z

Pull request #14233 was updated. @ghellwig, @covarell, @ianna, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @vanbesien, @govoni, @perrotta, @civanch, @franzoni, @cmsbuild, @fwyzard, @davidlange6, @Dr15Jones, @cvuosalo, @mdhildreth, @deguio, @slava77, @ggovi, @mmusich, @mulhearn, @perrozzi, @thuer, @dmitrijus, @srimanob, @hengne can you please check and sign again.

…date

cmsbuild · 2016-05-17T16:51:12Z

Pull request #14233 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

dmitrijus · 2016-05-17T17:58:43Z

+1

cmsbuild · 2016-05-17T17:58:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13031/console

cmsbuild · 2016-05-17T17:58:58Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-05-18T00:36:19Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-05-18T00:36:46Z

-1

Tested at: dc487ed

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dc487ed
883b82b
90717ff
b600055
cd46192
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14233/13031/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14233/13031/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14233/13031/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelClusterProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/RecoLocalTracker/SiPixelClusterizer/plugins/PixelThresholdClusterizer.cc 
Entering library rule at src/RecoLocalTracker/SiPixelClusterizer/test
>> Compiling LCG dictionary: tmp/slc6_amd64_gcc530/src/RecoLuminosity/LumiProducer/src/RecoLuminosityLumiProducer/a/RecoLuminosityLumiProducer_xr.cc
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp: In member function 'void clangcms::ConstCastChecker::checkPreStmt(const clang::CXXConstCastExpr_, clang::ento::CheckerContext&) const':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:30:47: error: 'class clang::ento::CheckerContext' has no member named 'generateErrorNode'
  if (clang::ento::ExplodedNode *errorNode = C.generateErrorNode()) {
                                               ^
Entering library rule at src/RecoLocalTracker/SiPixelClusterizer/test
Entering library rule at src/RecoLocalTracker/SiPixelClusterizer/test
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp: In member function 'void clangcms::ConstCastAwayChecker::checkPreStmt(const clang::ExplicitCastExpr_, clang::ento::CheckerContext&) const':

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

Selected class -> HcalUnpackerReport for ROOT: HcalUnpackerReport
Selected class -> HcalLaserDigi for ROOT: HcalLaserDigi
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/SimCalorimetry/HcalSimAlgos/src/HcalTDC.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/SimCalorimetry/HcalSimAlgos/src/HcalSiPMRecovery.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/SimCalorimetry/HcalSimAlgos/src/HPDNoiseMaker.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp:40:49: error: no member named 'generateErrorNode' in 'clang::ento::CheckerContext'
                if ( clang::ento::ExplodedNode *errorNode = C.generateErrorNode()) {
                                                            ~ ^
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/SimCalorimetry/HcalSimAlgos/src/HcalCoderFactory.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-05-17-1100/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp:30:47: error: no member named 'generateErrorNode' in 'clang::ento::CheckerContext'
        if (clang::ento::ExplodedNode *errorNode = C.generateErrorNode()) {

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dc487ed
883b82b
90717ff
b600055
cd46192
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14233/13031/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14233/13031/git-merge-result

Dr15Jones · 2016-05-18T11:50:03Z

@davidlt will this go away if the tests are rerun or does this problem require waiting longer for an IB with the new clang?

davidlt · 2016-05-18T12:16:05Z

@Dr15Jones needs 2300 May 18th IB for this to go away, which is not yet available.

production of input root files containing tracker map info for offlin…

698a0d6

…e TkCommissioner for better understanding SiStrip DQM issues

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 25, 2016

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 25, 2016

dmitrijus reviewed May 10, 2016
View reviewed changes

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 10, 2016

cmsbuild added tests-started and removed tests-pending labels May 10, 2016

dmitrijus reviewed May 10, 2016
View reviewed changes

cmsbuild added tests-approved and removed tests-started labels May 10, 2016

cmsbuild added comparison-available and removed comparison-pending labels May 10, 2016

davidlange6 reviewed May 12, 2016
View reviewed changes

vdutta added 2 commits May 17, 2016 17:24

Merged tkdqmoffline-tkcommissioner-inputs-81X from repository vdutta

b600055

delete pointers

3b671fa

cmsbuild added the pdmv-pending label May 17, 2016

Merge branch 'CMSSW_8_1_X' of https://github.com/cms-sw/cmssw into up…

dc487ed

…date

cmsbuild removed alca-pending analysis-pending db-pending generators-pending geometry-pending hlt-pending l1-pending operations-pending pdmv-pending reconstruction-pending labels May 17, 2016

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 17, 2016

cmsbuild added tests-started and removed tests-pending labels May 17, 2016

cmsbuild added tests-rejected and removed tests-started labels May 18, 2016

davidlange6 merged commit 90d8e45 into cms-sw:CMSSW_8_1_X May 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Input files for offline TkCommissioner tool, 81X #14233

Input files for offline TkCommissioner tool, 81X #14233

vdutta commented Apr 25, 2016

cmsbuild commented Apr 25, 2016

dmitrijus May 10, 2016

dmitrijus commented May 10, 2016

cmsbuild commented May 10, 2016 •

edited

cmsbuild commented May 10, 2016

dmitrijus May 10, 2016

cmsbuild commented May 10, 2016

cmsbuild commented May 10, 2016

davidlange6 May 12, 2016

fioriNTU commented May 17, 2016

cmsbuild commented May 17, 2016

cmsbuild commented May 17, 2016

dmitrijus commented May 17, 2016

cmsbuild commented May 17, 2016 •

edited

cmsbuild commented May 17, 2016

cmsbuild commented May 18, 2016

cmsbuild commented May 18, 2016

Dr15Jones commented May 18, 2016

davidlt commented May 18, 2016

Input files for offline TkCommissioner tool, 81X #14233

Input files for offline TkCommissioner tool, 81X #14233

Conversation

vdutta commented Apr 25, 2016

cmsbuild commented Apr 25, 2016

dmitrijus May 10, 2016

Choose a reason for hiding this comment

dmitrijus commented May 10, 2016

cmsbuild commented May 10, 2016 • edited

cmsbuild commented May 10, 2016

dmitrijus May 10, 2016

Choose a reason for hiding this comment

cmsbuild commented May 10, 2016

cmsbuild commented May 10, 2016

davidlange6 May 12, 2016

Choose a reason for hiding this comment

fioriNTU commented May 17, 2016

cmsbuild commented May 17, 2016

cmsbuild commented May 17, 2016

dmitrijus commented May 17, 2016

cmsbuild commented May 17, 2016 • edited

cmsbuild commented May 17, 2016

cmsbuild commented May 18, 2016

cmsbuild commented May 18, 2016

Dr15Jones commented May 18, 2016

davidlt commented May 18, 2016

cmsbuild commented May 10, 2016 •

edited

cmsbuild commented May 17, 2016 •

edited