Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing dictionaries related to BXVector #14241

Merged
merged 2 commits into from Apr 26, 2016
Merged

Added missing dictionaries related to BXVector #14241

merged 2 commits into from Apr 26, 2016

Conversation

Dr15Jones
Copy link
Contributor

This solves the problem seen by the Tier 0 repacking jobs:
https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3643.html

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Apr 25, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/L1TCalorimeter
DataFormats/L1TGlobal
DataFormats/L1TMuon
DataFormats/L1Trigger

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12627/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 4a1b684
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14241/12627/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14241/12627/summary.html

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 75b3e18 into cms-sw:CMSSW_8_0_X Apr 26, 2016
@Dr15Jones Dr15Jones deleted the addMissingL1Dict branch May 13, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @mulhearn @davidlange6