Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique_ptr, not auto_ptr, in HLT #14243

Merged
merged 1 commit into from Apr 26, 2016

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Apr 25, 2016

The last use of the deprecated std::auto_ptr in the CMS framework is the "put" interface for EDProducts, which also supports std::unique:ptr. This PR changes all put calls in HLT to use std::unique_ptr instead of std::auto_ptr. Some other instances of std::auto_ptr in HLT may also have been changed to std::unique_ptr.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Egamma
HLTrigger/HLTcore
HLTrigger/HLTfilters
HLTrigger/JetMET
HLTrigger/Muon
HLTrigger/Timer
HLTrigger/btau
HLTrigger/special
RecoEgamma/EgammaHLTProducers
RecoTauTag/HLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @imarches, @pvmulder, @acaudron, @abbiendi, @rafaellopesdesa, @jhgoh, @lgray, @Martin-Grunewald, @ferencek, @battibass, @trocino this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@wmtan
Copy link
Contributor Author

wmtan commented Apr 25, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12630/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 343bcbe into cms-sw:CMSSW_8_1_X Apr 26, 2016
@wmtan wmtan deleted the UseUniquePtrInHLT branch May 26, 2016 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants