Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel PU jet update #14269

Merged
merged 3 commits into from Apr 28, 2016
Merged

Pixel PU jet update #14269

merged 3 commits into from Apr 28, 2016

Conversation

silviodonato
Copy link
Contributor

This PR adds a JetTagCollection in the output of the module.
The JetTagCollection contains the sum of track pt as PU discriminant.
This change was required in order to exploit the pixel PU ID in the data scouting (@duanders).
This PR will not have any effect in the current HLT configuration, and so the HLT configuration doesn't need to be changed.
(I also changed the indentation of the code because it was a quite mess).
I will submit a backport to 80X as soon as this code will be approved.
Cheers, Silvio.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

please test

(diff ignoring fancy white-space indentation changes:
https://github.com/cms-sw/cmssw/pull/14269/files?w=1
)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12665/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

silviodonato added a commit to silviodonato/cmssw that referenced this pull request Apr 27, 2016
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5fb74b0 into cms-sw:CMSSW_8_1_X Apr 28, 2016
davidlange6 added a commit that referenced this pull request May 2, 2016
 Pixel PU jet update (backport of #14269 in 80X)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants