Fixed SIM exception actions #14289

civanch · 2016-04-28T09:16:39Z

When a problem happens during SIM step SimG4Exception happens, OscarMTProducer should throw edm::Exception instead of the abort. This PR address the issue #14273

cmsbuild · 2016-04-28T09:18:45Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_8_1_X.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

civanch · 2016-04-28T09:22:24Z

please test

cmsbuild · 2016-04-28T09:22:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12685/console

civanch · 2016-04-28T09:22:28Z

+1

cmsbuild · 2016-04-28T09:23:11Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-04-28T11:12:17Z

+1
Tested at: 2cab65c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14289/12685/summary.html

cmsbuild · 2016-04-28T12:20:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14289/12685/summary.html

Dr15Jones · 2016-04-28T13:48:03Z

SimG4Core/Application/plugins/OscarProducer.cc

 					 << simg4ex.what();

-    m_runManager->abortEvent();


This seems to be needed to properly clear Geant's internals in the case of a failure.
Also, for the original problem from the issue, produce is never called since the job is ending before entering the event loop.

Dr15Jones · 2016-04-28T13:50:35Z

Maybe I'm missing something, but it is unclear to me how these changes fix the problem reported in #14273. I had thought that the origin of the problem was if one creates a OscarMTProducer and then ends the job before calling beginJob or beginRun. As far as I can see non of these changes would help that case.

Dr15Jones · 2016-04-28T13:52:17Z

hold

cmsbuild · 2016-04-28T13:52:58Z

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

civanch · 2016-04-28T16:40:06Z

+1

cmsbuild · 2016-04-28T16:40:17Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-04-28T17:23:59Z

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14289/12696/git-merge-result

cmsbuild · 2016-04-28T21:03:38Z

-1

Tested at: b32d011

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14289/12706/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
134.911 step2

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

10021.0 step2

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Thu Apr 28 22:55:54 2016-date Thu Apr 28 22:53:28 2016 s - exit: 16896
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Thu Apr 28 22:55:41 2016-date Thu Apr 28 22:53:32 2016 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Apr 28 22:58:18 2016-date Thu Apr 28 22:53:35 2016 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Thu Apr 28 22:57:27 2016-date Thu Apr 28 22:53:41 2016 s - exit: 16896
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Thu Apr 28 22:59:01 2016-date Thu Apr 28 22:53:44 2016 s - exit: 16896
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Thu Apr 28 22:55:59 2016-date Thu Apr 28 22:53:49 2016 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Thu Apr 28 22:57:28 2016-date Thu Apr 28 22:53:54 2016 s - exit: 16896
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Thu Apr 28 22:57:57 2016-date Thu Apr 28 22:54:07 2016 s - exit: 16896
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Thu Apr 28 22:57:52 2016-date Thu Apr 28 22:54:12 2016 s - exit: 16896

civanch · 2016-04-29T09:24:31Z

please test

cmsbuild · 2016-04-29T09:24:52Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12715/console

cmsbuild · 2016-04-29T11:24:19Z

+1
Tested at: b32d011
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14289/12715/summary.html

cmsbuild · 2016-04-29T12:29:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14289/12715/summary.html

davidlange6 · 2016-05-01T07:50:49Z

+1

fixed SIM exception actions

2cab65c

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 28, 2016

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 28, 2016

cmsbuild added simulation-approved fully-signed tests-started and removed pending-signatures simulation-pending tests-pending labels Apr 28, 2016

civanch mentioned this pull request Apr 28, 2016

OscarMTMasterThread does not handle failures properly #14273

Closed

cmsbuild added tests-approved and removed tests-started labels Apr 28, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 28, 2016

Dr15Jones reviewed Apr 28, 2016
View reviewed changes

cmsbuild added simulation-approved fully-signed tests-started and removed pending-signatures simulation-pending tests-pending labels Apr 28, 2016

cmsbuild added tests-rejected and removed tests-started labels Apr 28, 2016

cmsbuild added tests-pending and removed tests-rejected labels Apr 29, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 29, 2016

cmsbuild added tests-approved and removed tests-started labels Apr 29, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 29, 2016

cmsbuild added orp-approved and removed orp-pending labels May 1, 2016

cmsbuild merged commit 9c16e09 into cms-sw:CMSSW_8_1_X May 1, 2016

civanch mentioned this pull request May 7, 2016

Clean-up Sim Exceptions #14405

Merged

civanch mentioned this pull request Sep 22, 2016

Backported fix for correct handling of stop of run in SIM producer #15960

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed SIM exception actions #14289

Fixed SIM exception actions #14289

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016 •

edited

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

Dr15Jones Apr 28, 2016

Dr15Jones commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

civanch commented Apr 29, 2016

cmsbuild commented Apr 29, 2016 •

edited

cmsbuild commented Apr 29, 2016

cmsbuild commented Apr 29, 2016

davidlange6 commented May 1, 2016

Fixed SIM exception actions #14289

Fixed SIM exception actions #14289

Conversation

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016 • edited

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

Dr15Jones Apr 28, 2016

Choose a reason for hiding this comment

Dr15Jones commented Apr 28, 2016

Dr15Jones commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

civanch commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

cmsbuild commented Apr 28, 2016

civanch commented Apr 29, 2016

cmsbuild commented Apr 29, 2016 • edited

cmsbuild commented Apr 29, 2016

cmsbuild commented Apr 29, 2016

davidlange6 commented May 1, 2016

cmsbuild commented Apr 28, 2016 •

edited

cmsbuild commented Apr 29, 2016 •

edited