Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make statics class members #1430

Merged
merged 4 commits into from Nov 14, 2013
Merged

make statics class members #1430

merged 4 commits into from Nov 14, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Nov 12, 2013

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

make statics class members

It involves the following packages:

RecoMET/METAlgorithms

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

If the CSCHaloAlgo is made every every (which I haven't checked) then you'd get the same message every event, which that static would have avoided. If the CSCHaloAlgo sticks around a long time, it's not a big deal.

@cmsbuild
Copy link
Contributor

Pull request #1430 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

{
static bool MuonTimeFail = false;
{
static std::atomic<bool> MuonTimeFail{false};
if( !MuonTimeFail )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On each of the `if`` blocks you will want to change them to

bool expected=false;
if(MuonTimeFail.compare_exchange_strong(expected,true,std::memory_order_acq_rel) ) {

and then get rid of the MuonTimeFail = true.

@cmsbuild
Copy link
Contributor

Pull request #1430 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

@Dr15Jones
Copy link
Contributor

Looks good to me.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Nov 14, 2013

+1
Tested 063c9cb in CMSSW_7_0_X_2013-11-14-0200-1430
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 14, 2013
Multithreading fixes -- Make statics class members in RecoMET/METAlgorithms
@ktf ktf merged commit a614134 into cms-sw:CMSSW_7_0_X Nov 14, 2013
@gartung gartung deleted the statics-RecoMET-METAlgorithms branch November 14, 2013 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants