define RecoFullLocal and use in Phase2 upgrade workflows #14307
Conversation
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: Configuration/PyReleaseValidation @cvuosalo, @fabozzi, @cmsbuild, @srimanob, @slava77, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| @@ -98,15 +98,15 @@ | |||
| # step5 is digi+l1tracktrigger | |||
| # step6 is fastsim | |||
| # step7 is fastsim harvesting | |||
| upgradeSteps=['GenSimFull','GenSimHLBeamSpotFull','DigiFull','DigiFulllocalreco','RecoFull','RecoFullHGCAL','HARVESTFull','DigiTrkTrigFull','FastSim','HARVESTFast','DigiFullPU','RecoFullPU','RecoFullPUHGCAL','HARVESTFullPU','DigiFullTrigger'] | |||
| upgradeSteps=['GenSimFull','GenSimHLBeamSpotFull','DigiFull','DigiFulllocalreco','RecoFull','RecoFullLocal','RecoFullHGCAL','HARVESTFull','DigiTrkTrigFull','FastSim','HARVESTFast','DigiFullPU','RecoFullPU','RecoFullPUHGCAL','HARVESTFullPU','DigiFullTrigger'] | |||
There was a problem hiding this comment.
@kpedro88 - could we just remove DigiFulllocalreco here (and maybe better, put RecoFulLocal in its place so that the workflow numbers stay the same?
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@hengne @slava77 @davidlange6 - signatures please |
|
+1 |
|
Extended testing in progress... |
|
+1 Adding RECO step to 2023 upgrade workflows. There should be no change in standard workflows. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-04-29-2300 show no significant differences, as expected. Some of the Jenkins results show tiny fluctuations that may be caused by some uninitialized variable or other bug somewhere, but this issue is not related to this PR. An extended test of workflows 10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017 and 11024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023LReco against baseline CMSSW_8_1_X_2016-04-28-2300 show no significant differences or problems. The addition of the RECO step (step3) is confirmed in 2023 workflow 11024.0. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
+1 |
Based on an email discussion with @VinInn, for Phase2 RECO development, it's better to have a separate step3 with (for the moment) RAW2DIGI, L1Reco, RECO:localreco.
Also, this PR fixes a small bug in the HCAL upgrade reco input settings, which wasn't noticeable with the previous workflows combining step2 and step3.