bsunanda:Run2-hcx78 Correct access of HcalTopology #14313
Conversation
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/HcalTPGEventSetup @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @cerminar, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -37,24 +37,25 @@ | |||
| #include "CalibFormats/HcalObjects/interface/HcalDbRecord.h" | |||
| #include "FWCore/Framework/interface/ESHandle.h" | |||
| #include "Geometry/CaloTopology/interface/HcalTopology.h" | |||
| #include "Geometry/HcalCommonData/interface/HcalDDDRecConstants.h" | |||
| XERCES_CPP_NAMESPACE_USE | |||
| // | |||
| // class decleration | |||
| // | |||
|
|
|||
| class WriteL1TriggerObjetsXml : public edm::EDAnalyzer { | |||
There was a problem hiding this comment.
@bsunanda - please, use thread safe analyser
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #14313 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @cerminar, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #14313 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @cerminar, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
|
@ggovi @mulhearn @davidlange6 Can you push this PR into IB so that one can make the next step for topology usage? |
|
+1 |
Also extend some of the services of HcalDDDRecConstant to enable finer indexing in eta/phi