Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx79 Add 2 more methods to HcalDetId #14314

Merged
merged 1 commit into from May 4, 2016

Conversation

bsunanda
Copy link
Contributor

Needed for new HF reconstruction

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 30, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12745/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

DataFormats/HcalDetId

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented May 1, 2016

+1
Workflow 1001.0 does not complited but it is not connected with this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@bsunanda - the logic is getting quite complex for such basic level functions - perhaps you should define a mask that unifies all of these conditionals?

@cmsbuild cmsbuild merged commit 234940c into cms-sw:CMSSW_8_1_X May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants