Filling the fillDescription method of CaloRecHitsBeamHaloCleaned and … #14331
Conversation
…adding the corresponding generated config file
|
A new Pull Request was created by @lathomas for CMSSW_8_0_X. It involves the following packages: RecoMET/METProducers @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -0,0 +1,9 @@ | |||
| import FWCore.ParameterSet.Config as cms | |||
|
|
|||
| CaloRecHitsBeamHaloCleaned = cms.EDProducer('CaloRecHitsBeamHaloCleaned', | |||
There was a problem hiding this comment.
please use lower case for class module instance names
and have the file name also start with the lower case letter
There was a problem hiding this comment.
actually, it's better not to make this file at all and use what the system will generate based on the fillDescriptions defaults: it will make caloRecHitsBeamHaloCleaned_cfi.py file in $CMSSW_BASE/python
…adding the corresponding generated config file
|
@slava77 Ok, thanks for the prompt feedback. I updated the changes (also in 81X). Let me know if it's fine now. Thanks ! |
|
please keep #14332 in sync as well. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 Adding some parameters to the fillDescription method of CaloRecHitsBeamHaloCleaned. There should be no change in monitored quantities. #14332 is the 81X version of this PR. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-05-02-1100 show no significant differences, as expected. |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
@davidlange6 @slava77 Thanks a lot ! |
|
+1 |
…adding the corresponding generated config file.
The producer CaloRecHitsBeamHaloCleaned is needed for the design of a new trigger path. The changes are required in order to parse theconfig in ConfDB.