Add pixel-only seed extension

[makortel]

This PR adds a "pixel-only" flavour of the SeedExtensionTrajectoryFilter (one of the explored pixel-quadruplet approaches for phase1). As a prerequisite, Trajectory and TempTrajectory are extended to count also found pixel hits (which may have other uses too).

The SeedExtensionTrajectoryFilter is also extended to act as "qualityFilter()" in addition to "toBeContinued()". The point is that if seed extension decides that a propagation of a trajectory should be stopped, the trajectory should also be discarded (in my opinion). This way the assumption is enforced without relying on the value of minimumNumberOfHits (alternatively we would need minimumNumberOfPixelHits). The easiest way to communicate the "trajectory was stopped because of seed extension" from toBeContinued() to qualityFilter() was to use the existing StoppingReason enum, so I added a SEED_EXTENSION enumerator there.

I updated the tracking DQM for the new StoppingReason (*), also adding a run-time check in case new StoppingReasons are added. (Maybe we should eventually abstract the string representation of StoppingReasons similarly to TrackBase::TrackAlgorithm?)

(*) After the "qualityFilter()" change we expect to see zero tracks with SEED_EXTENSION stopping reason, so the DQM change serves mainly as a sanity check (seeing something there indicates a bug).

Tested in CMSSW_8_1_X_2016-05-01-2300 (rebased on top of CMSSW_8_1_X_2016-05-09-2300 CMSSW_8_1_X_2016-05-16-2300), no changes expected in standard workflows (new functionality is added but not enabled; StopReason DQM plots show changes because of added bin).

@rovere @VinInn @mtosi

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

DQM/TrackingMonitor
DataFormats/TrackReco
HLTrigger/Configuration
TrackingTools/PatternTools
TrackingTools/TrajectoryFiltering

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @dmitrijus, @Martin-Grunewald, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@geoff-smith, @battibass, @threus, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @Martin-Grunewald, @bellan, @HuguesBrun, @rovere, @jalimena, @gpetruc, @cerati, @trocino, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12795/console

[cmsbuild]

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14356/12795/git-merge-result

[makortel]

error: RPC failed; result=7, HTTP code = 0
fatal: The remote end hung up unexpectedly

Looks like a transient issue, maybe try again?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12802/console

[cmsbuild]

+1
Tested at: 584b548
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14356/12802/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14356/12802/summary.html

[Martin-Grunewald]

+1

[cmsbuild]

+1
Tested at: 97c8106
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14356/13033/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14356/13033/summary.html

[slava77]

+1

for #14356 97c8106

• code change is in line with the description.
• jenkins test pass and comparisons with baseline show differences only in DQM plots of stoppingSource, which changed due to increase in binning range
• local tests with 134.905 (2015 MET events) show that about 0.05% of reco time is spent in the new Trajectory::pixel method calls https://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/CMSSW_8_1_X_2016-05-18-1100-sign698-cvmfs.134.905.step3.200.pp/3100 This should be tolerable.

[Martin-Grunewald]

+1

[slava77]

@dmitrijus
your signature is needed here
Please check.
Thank you.

Merging of this PR is now blocking further developments

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1