Add new signal to ActivityRegistry around when a #14360
Conversation
source is called during processing of an event to get a product using DelayedRead.
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_8_1_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
| class DelayedReader { | ||
| public: | ||
| virtual ~DelayedReader(); | ||
| virtual std::unique_ptr<WrapperBase> getProduct(BranchKey const& k, EDProductGetter const* ep); | ||
|
|
||
| std::unique_ptr<WrapperBase> getProduct(BranchKey const& k, EDProductGetter const* ep); |
There was a problem hiding this comment.
Why do we need to keep the old interface?
|
Pull request #14360 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again. |
|
Please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: 3913e42 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS |
source is called during processing of an event
to get a product using DelayedRead. This should be
useful when measuring stall time in multithreaded processes.